Once codereview.chromium.org/11614037/ get checked-in, chromium will support OES_texture_half_float extension. This patch will enable the HALF_FLOAT_OES tests in chromium bots. DumpRenderTree doesn't advertise OES_texture_half_float (seems like DRT in chromium uses software composition), hence expected results for chromium platform differs.
Created attachment 191375 [details] Patch
Comment on attachment 191375 [details] Patch Attachment 191375 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16989076 New failing tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
Comment on attachment 191375 [details] Patch Attachment 191375 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17033071 New failing tests: editing/selection/selection-invalid-offset.html fast/canvas/webgl/oes-texture-half-float-not-supported.html
Comment on attachment 191375 [details] Patch Sorry if this wasn't clear, but the patch has to pass the EWS bots.
Created attachment 194967 [details] Fix for test failure in mac bots
Comment on attachment 194967 [details] Fix for test failure in mac bots Attachment 194967 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17255446 New failing tests: platform/chromium/virtual/gpu/fast/canvas/webgl/oes-texture-half-float-not-supported.html fast/canvas/webgl/oes-texture-half-float-not-supported.html
Created attachment 194990 [details] Archive of layout-test-results from gce-cr-linux-05 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-05 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 194967 [details] Fix for test failure in mac bots This looks like it's still failing on some of the bots.
Created attachment 195160 [details] Patch
Comment on attachment 195160 [details] Patch Clearing the review flag as bots still seems to report failure. Presence of <video> tag seems to be causing weird behavior. I'll investigate and resubmit the new patch.
Comment on attachment 195160 [details] Patch Attachment 195160 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17304346 New failing tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
Created attachment 195173 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 195180 [details] Patch
Comment on attachment 195180 [details] Patch Attachment 195180 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17338075
(In reply to comment #14) > (From update of attachment 195180 [details]) > Attachment 195180 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17338075 win bot failure seems to be unrelated to this change. (https://bugs.webkit.org/show_bug.cgi?id=113007 reports same crash)
Comment on attachment 195180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195180&action=review Given today's announcement regarding the Chromium project, I'm not sure I should review this patch. However, these changes look undesirable for any WebKit port, so marking it r-. > LayoutTests/fast/canvas/webgl/oes-texture-half-float-not-supported.html:144 > + } Moving this call here is the wrong thing to do. Instead, make sure finishTest() is called on all of the other code paths in the test. > LayoutTests/fast/canvas/webgl/oes-texture-half-float-not-supported.html:-154 > - "playing", function() { runTextureUploadTest(video); finishTest(); }, true); This change, and the duplication of finishTest() as finish(), is undesirable.