Bug 111385 - Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
Summary: Add audio hardware support for multi-channel by implementing AudioDestination...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 17:25 PST by Chris Rogers
Modified: 2013-03-04 22:06 PST (History)
13 users (show)

See Also:

Attachments
Patch (14.28 KB, patch)
2013-03-04 17:38 PST, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2013-03-04 17:25:17 PST 
Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
Comment 1 Chris Rogers 2013-03-04 17:38:28 PST 
Created attachment 191362 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-04 17:42:39 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kenneth Russell 2013-03-04 18:10:29 PST 
Comment on attachment 191362 [details]
Patch

Looks good. Verified that the exception behavior matches the spec and that the default output is still stereo.

Deferring r+ to one of the Chromium API reviewers.
Comment 4 James Robinson 2013-03-04 18:11:18 PST 
Comment on attachment 191362 [details]
Patch

WK API looks good
Comment 5 WebKit Review Bot 2013-03-04 22:06:29 PST 
Comment on attachment 191362 [details]
Patch

Clearing flags on attachment: 191362

Committed r144720: <http://trac.webkit.org/changeset/144720>
Comment 6 WebKit Review Bot 2013-03-04 22:06:34 PST 
All reviewed patches have been landed.  Closing bug.