Bug 111384 - run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
Summary: run-webkit-tests should support --profile and --profiler= just like run-perf-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 16:53 PST by Eric Seidel (no email)
Modified: 2013-03-04 21:57 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2013-03-04 16:55 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-03-04 16:53:43 PST
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
Comment 1 Eric Seidel (no email) 2013-03-04 16:55:13 PST
Created attachment 191355 [details]
Patch
Comment 2 Dirk Pranke 2013-03-04 16:58:33 PST
Comment on attachment 191355 [details]
Patch

I wonder if it makes sense to split out some of the options into a separate group if they are shared between layout tests and perf tests (much like we have configuration_options and platform_options)?
Comment 3 Eric Seidel (no email) 2013-03-04 17:00:50 PST
Long ago I had a dream of moving NRWT's options down onto the objects which they applied to.  In this case, these could move onto Driver or Port.

webkit-patch does similar with its "steps" abstraction.

So yes, I believe moving things like this to shared locations is good. :)
Comment 4 WebKit Review Bot 2013-03-04 21:57:11 PST
Comment on attachment 191355 [details]
Patch

Clearing flags on attachment: 191355

Committed r144719: <http://trac.webkit.org/changeset/144719>
Comment 5 WebKit Review Bot 2013-03-04 21:57:14 PST
All reviewed patches have been landed.  Closing bug.