RESOLVED FIXED 111384
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does 
https://bugs.webkit.org/show_bug.cgi?id=111384
Summary run-webkit-tests should support --profile and --profiler= just like run-perf-...
Eric Seidel (no email)
Reported 2013-03-04 16:53:43 PST
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
Attachments
Patch (2.00 KB, patch)
2013-03-04 16:55 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-03-04 16:55:13 PST
Created attachment 191355 [details] Patch
Dirk Pranke
Comment 2 2013-03-04 16:58:33 PST
Comment on attachment 191355 [details] Patch I wonder if it makes sense to split out some of the options into a separate group if they are shared between layout tests and perf tests (much like we have configuration_options and platform_options)?
Eric Seidel (no email)
Comment 3 2013-03-04 17:00:50 PST
Long ago I had a dream of moving NRWT's options down onto the objects which they applied to. In this case, these could move onto Driver or Port. webkit-patch does similar with its "steps" abstraction. So yes, I believe moving things like this to shared locations is good. :)
WebKit Review Bot
Comment 4 2013-03-04 21:57:11 PST
Comment on attachment 191355 [details] Patch Clearing flags on attachment: 191355 Committed r144719: <http://trac.webkit.org/changeset/144719>
WebKit Review Bot
Comment 5 2013-03-04 21:57:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.