Bug 111381 – Upgrade ANGLE to r1987

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

ANGLE needs to be upgraded to r1987 to pick up proper conditional support for highp in fragment shaders on OpenGL ES 2.0 platforms. The ports need to be updated to properly query for support and enable it.

[Kenneth Russell]

Created attachment 191347 [details]
Patch

[WebKit Review Bot]

Attachment 191347 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h:61:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 191347 [details]
Patch

Attachment 191347 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16903196

[Early Warning System Bot]

Comment on attachment 191347 [details]
Patch

Attachment 191347 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16923049

[Kenneth Russell]

Created attachment 191366 [details]
Fixed Qt build failure

[WebKit Review Bot]

Attachment 191366 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h', u'Source/ThirdParty/ANGLE/src/common/version.h', u'Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp', u'Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h', u'Source/ThirdParty/ANGLE/src/compiler/ShHandle.h', u'Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp', u'Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang.l', u'Source/ThirdParty/ANGLE/src/compiler/glslang.y', u'Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp', u'Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp', u'Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp', u'Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp', u'Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm', u'Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h:61:  One space before end of line comments  [whitespace/comments] [5]
Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp:761:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 191366 [details]
Fixed Qt build failure

Clearing flags on attachment: 191366

Committed r144833: <http://trac.webkit.org/changeset/144833>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.