Bug 111373 - [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
Summary: [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 16:05 PST by Andrew Lo
Modified: 2013-03-05 04:55 PST (History)
5 users (show)

See Also:

Attachments
Patch (14.34 KB, patch)
2013-03-04 16:12 PST, Andrew Lo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2013-03-04 16:05:55 PST 
Rename some functions & variables to reflect that they are used for both block zoom and generic zoom/scroll animations.

Have WebPageClient pass the final scale and position to WebPage when animation finishes, rather than keeping those values as instance variables in WebPagePrivate.
Comment 1 Andrew Lo 2013-03-04 16:12:47 PST 
Created attachment 191338 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-04 18:11:29 PST 
Comment on attachment 191338 [details]
Patch

Attachment 191338 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16958018

New failing tests:
inspector/debugger/watch-expressions-panel-switch.html
Comment 3 Rob Buis 2013-03-05 04:35:17 PST 
Comment on attachment 191338 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2013-03-05 04:55:38 PST 
Comment on attachment 191338 [details]
Patch

Clearing flags on attachment: 191338

Committed r144750: <http://trac.webkit.org/changeset/144750>
Comment 5 WebKit Review Bot 2013-03-05 04:55:42 PST 
All reviewed patches have been landed.  Closing bug.