RESOLVED FIXED111373
[BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate 
https://bugs.webkit.org/show_bug.cgi?id=111373
Summary [BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
Andrew Lo
Reported 2013-03-04 16:05:55 PST
Rename some functions & variables to reflect that they are used for both block zoom and generic zoom/scroll animations. Have WebPageClient pass the final scale and position to WebPage when animation finishes, rather than keeping those values as instance variables in WebPagePrivate.
Attachments
Patch (14.34 KB, patch)
2013-03-04 16:12 PST, Andrew Lo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrew Lo
Comment 1 2013-03-04 16:12:47 PST
Created attachment 191338 [details] Patch
WebKit Review Bot
Comment 2 2013-03-04 18:11:29 PST
Comment on attachment 191338 [details] Patch Attachment 191338 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16958018 New failing tests: inspector/debugger/watch-expressions-panel-switch.html
Rob Buis
Comment 3 2013-03-05 04:35:17 PST
Comment on attachment 191338 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2013-03-05 04:55:38 PST
Comment on attachment 191338 [details] Patch Clearing flags on attachment: 191338 Committed r144750: <http://trac.webkit.org/changeset/144750>
WebKit Review Bot
Comment 5 2013-03-05 04:55:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.