Bug 111357 - Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
Summary: Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
Depends on:
Reported: 2013-03-04 12:44 PST by Pavel Feldman
Modified: 2013-03-07 00:11 PST (History)
9 users (show)

See Also:

Patch (6.88 KB, patch)
2013-03-05 01:07 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2013-03-04 12:44:14 PST
We should only consume Cmd+L on the source files.
Comment 1 Eugene Klyuchnikov 2013-03-05 01:00:39 PST
Go-to-Line dialog is installed in 3 panels. But in most cases it can't be activated because no line-based views are shown.

I propose to turn shortcut "handlers" to be handlers. This means that they should return true IFF they actually performed some action.
Comment 2 Eugene Klyuchnikov 2013-03-05 01:07:08 PST
Created attachment 191427 [details]
Comment 3 WebKit Review Bot 2013-03-07 00:11:03 PST
Comment on attachment 191427 [details]

Clearing flags on attachment: 191427

Committed r145045: <http://trac.webkit.org/changeset/145045>
Comment 4 WebKit Review Bot 2013-03-07 00:11:07 PST
All reviewed patches have been landed.  Closing bug.