Bug 111342 – table element may get larger when its contents are recreated

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Michael Spang]

I have some JS code that populates a table element. Every time this function runs, the table gets a few pixels taller despite equivalent contents.

HTML file to demonstrate this is attached.

[Michael Spang]

Created attachment 191263 [details]
html demonstrating the bug

[Robert Hogan]

This extra height that keeps accumulating is the vertical border-spacing.

[Robert Hogan]

Created attachment 195958 [details]
Patch

[Build Bot]

Comment on attachment 195958 [details]
Patch

Attachment 195958 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17387119

New failing tests:
fast/table/anonymous-table-section-removed.html
fast/text/emphasis-height-crash.html

[Build Bot]

Created attachment 195971 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Build Bot]

Comment on attachment 195958 [details]
Patch

Attachment 195958 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17305473

New failing tests:
fast/table/anonymous-table-section-removed.html
fast/text/emphasis-height-crash.html

[Build Bot]

Created attachment 195979 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Darin Adler]

Comment on attachment 195958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195958&action=review

> LayoutTests/fast/table/anonymous-table-section-removed-expected.txt:2
> +PASS

check-layout.js is annoyingly terse; sure would be nice to say more than just PASS

> LayoutTests/fast/table/anonymous-table-section-removed.html:9
> +        document.body.offsetHeight;

Irritating that we don’t have a more natural way to force layout. I know we rely on this a lot in tons of tests, but I’d rather have it be through a function so we can fix it in one place if we have to. Some day we might want to optimize calls to get property values that don’t examine the function result ;-)

> LayoutTests/fast/table/anonymous-table-section-removed.html:14
> +    checkLayout('table')

A little strange to omit the semicolon here.

[Robert Hogan]

Created attachment 196775 [details]
Patch

[Build Bot]

Comment on attachment 196775 [details]
Patch

Attachment 196775 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17525675

New failing tests:
fast/table/anonymous-table-section-removed.html

[Build Bot]

Created attachment 196778 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Robert Hogan]

Created attachment 196781 [details]
Patch

[Build Bot]

Comment on attachment 196781 [details]
Patch

Attachment 196781 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17526651

New failing tests:
fast/table/anonymous-table-section-removed.html
fast/repaint/japanese-rl-selection-repaint-in-regions.html

[Build Bot]

Created attachment 196784 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Robert Hogan]

Created attachment 196788 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 196788 [details]
Patch

Clearing flags on attachment: 196788

Committed r147871: <http://trac.webkit.org/changeset/147871>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Very exciting!  Thank you!