Bug 111339 - AX: user agent shadow roots for plugins should be 'accessible'
Summary: AX: user agent shadow roots for plugins should be 'accessible'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-03-04 09:16 PST by chris fleizach
Modified: 2013-03-04 15:48 PST (History)
5 users (show)

See Also:

Attachments
patch (1.72 KB, patch)
2013-03-04 09:19 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-03-04 09:16:02 PST 
Right now the user agent shadow root adds a title and subtitle to some divs.

To make it accessible, we should turn the overall div into a button and concatenate the title/subtitle and use that as the aria-label
Comment 1 chris fleizach 2013-03-04 09:16:17 PST 
rdar://12998748
Comment 2 chris fleizach 2013-03-04 09:19:29 PST 
Created attachment 191258 [details]
patch
Comment 3 chris fleizach 2013-03-04 09:20:55 PST 
Adding Jon and Dean for review. Please let me know if there's a good way to do a layout test for this, I couldn't find any examples
Comment 4 Tim Horton 2013-03-04 15:22:01 PST 
Comment on attachment 191258 [details]
patch

Seems reasonable.
Comment 5 WebKit Review Bot 2013-03-04 15:48:05 PST 
Comment on attachment 191258 [details]
patch

Clearing flags on attachment: 191258

Committed r144690: <http://trac.webkit.org/changeset/144690>
Comment 6 WebKit Review Bot 2013-03-04 15:48:09 PST 
All reviewed patches have been landed.  Closing bug.