RESOLVED FIXED 111328
[chromium] pass all focus handling methods through the WebTestDelegate 
https://bugs.webkit.org/show_bug.cgi?id=111328
Summary [chromium] pass all focus handling methods through the WebTestDelegate
jochen
Reported 2013-03-04 07:33:53 PST
[chromium] pass all focus handling methods through the WebTestDelegate
Attachments
Patch (7.35 KB, patch)
2013-03-04 07:34 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-03-04 07:34:47 PST
Created attachment 191240 [details] Patch
WebKit Review Bot
Comment 2 2013-03-04 07:39:58 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Nico Weber
Comment 3 2013-03-04 07:49:14 PST
Comment on attachment 191240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191240&action=review > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:427 > + Base::didFocus(); nit: the other methods in this class tend to call the Base:: version first
jochen
Comment 4 2013-03-04 07:56:49 PST
(In reply to comment #3) > (From update of attachment 191240 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191240&action=review > > > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:427 > > + Base::didFocus(); > > nit: the other methods in this class tend to call the Base:: version first no, Base:: is almost everywhere the second call
WebKit Review Bot
Comment 5 2013-03-04 09:06:36 PST
Comment on attachment 191240 [details] Patch Clearing flags on attachment: 191240 Committed r144635: <http://trac.webkit.org/changeset/144635>
WebKit Review Bot
Comment 6 2013-03-04 09:06:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.