Bug 111328 - [chromium] pass all focus handling methods through the WebTestDelegate
Summary: [chromium] pass all focus handling methods through the WebTestDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 07:33 PST by jochen
Modified: 2013-03-04 09:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.35 KB, patch)
2013-03-04 07:34 PST, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-03-04 07:33:53 PST 
[chromium] pass all focus handling methods through the WebTestDelegate
Comment 1 jochen 2013-03-04 07:34:47 PST 
Created attachment 191240 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-04 07:39:58 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Nico Weber 2013-03-04 07:49:14 PST 
Comment on attachment 191240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191240&action=review

> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:427
> +        Base::didFocus();

nit: the other methods in this class tend to call the Base:: version first
Comment 4 jochen 2013-03-04 07:56:49 PST 
(In reply to comment #3)
> (From update of attachment 191240 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191240&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:427
> > +        Base::didFocus();
> 
> nit: the other methods in this class tend to call the Base:: version first

no, Base:: is almost everywhere the second call
Comment 5 WebKit Review Bot 2013-03-04 09:06:36 PST 
Comment on attachment 191240 [details]
Patch

Clearing flags on attachment: 191240

Committed r144635: <http://trac.webkit.org/changeset/144635>
Comment 6 WebKit Review Bot 2013-03-04 09:06:40 PST 
All reviewed patches have been landed.  Closing bug.