Bug 111311 - MediaStream API: Add the getStreamById method on RTCPeerConnection
Summary: MediaStream API: Add the getStreamById method on RTCPeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords: WebExposed
Depends on:
Blocks: 56459 111410
  Show dependency tree / graph
 
Reported: 2013-03-04 06:26 PST by Tommy Widenflycht
Modified: 2013-03-05 03:44 PST (History)
13 users (show)

See Also:

Attachments
Patch (14.18 KB, patch)
2013-03-04 06:34 PST, Tommy Widenflycht 		abarth: review+
Details | Formatted Diff | Diff
Patch for landing (14.18 KB, patch)
2013-03-05 01:08 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch for landing (15.02 KB, patch)
2013-03-05 01:37 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2013-03-04 06:26:46 PST 
MediaStream API: Add the getStreamById method on RTCPeerConnection
Comment 1 Tommy Widenflycht 2013-03-04 06:34:15 PST 
Created attachment 191224 [details]
Patch
Comment 2 Tommy Widenflycht 2013-03-04 06:37:16 PST 
Also took the opportunity to fix the readyState handling of MediaStreamSource. It is allowed to set the readystate to ended more than once.
Comment 3 WebKit Review Bot 2013-03-04 06:38:13 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2013-03-04 12:49:47 PST 
Comment on attachment 191224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191224&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:434
> +MediaStream* RTCPeerConnection::getStreamById(String streamId)

String -> const String&

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:438
> +            return (*iter).get();

(*iter).get()   ->    iter->get()   ?
Comment 5 Tommy Widenflycht 2013-03-05 01:08:29 PST 
Created attachment 191428 [details]
Patch for landing
Comment 6 Tommy Widenflycht 2013-03-05 01:09:12 PST 
Comment on attachment 191224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191224&action=review

>> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:434
>> +MediaStream* RTCPeerConnection::getStreamById(String streamId)
> 
> String -> const String&

Fixed.

>> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:438
>> +            return (*iter).get();
> 
> (*iter).get()   ->    iter->get()   ?

Done.
Comment 7 Tommy Widenflycht 2013-03-05 01:37:35 PST 
Created attachment 191437 [details]
Patch for landing
Comment 8 Tommy Widenflycht 2013-03-05 01:38:49 PST 
Removed a TestExpectations exception for a test in the latest patch because this code fixes the issue.
Comment 9 WebKit Review Bot 2013-03-05 03:36:40 PST 
Comment on attachment 191437 [details]
Patch for landing

Clearing flags on attachment: 191437

Committed r144748: <http://trac.webkit.org/changeset/144748>