ASSIGNED 111310
[WK2] Add unit tests for CoreIPC 
https://bugs.webkit.org/show_bug.cgi?id=111310
Summary [WK2] Add unit tests for CoreIPC
Thiago Marcos P. Santos
Reported 2013-03-04 06:19:28 PST
Add some tests to test things like the Connection abstraction, encoder/decoders, synchronous messages from threads, etc. The test will isolate the CoreIPC code from the rest of WebKit, making it easier to optimize and debug.
Attachments
Patch (18.49 KB, patch)
2013-03-04 06:40 PST, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2013-03-04 06:40:20 PST
Created attachment 191227 [details] Patch
Benjamin Poulain
Comment 2 2013-03-06 10:34:19 PST
Comment on attachment 191227 [details] Patch No modified xcode project files??
Thiago Marcos P. Santos
Comment 3 2013-03-06 12:46:24 PST
(In reply to comment #2) > (From update of attachment 191227 [details]) > No modified xcode project files?? No, this test is Unix only because of the exact same platform dependency CoreIPC has for its initialization: socket creation. There is work being done on bug 110978 to address this, but I am fine with other platform maintainers adding #ifdefs for their platforms on the test meanwhile.
Benjamin Poulain
Comment 4 2013-03-06 12:52:20 PST
Why not create platform abstraction like PlatformWebView?
Thiago Marcos P. Santos
Comment 5 2013-03-06 13:41:19 PST
(In reply to comment #4) > Why not create platform abstraction like PlatformWebView? It can be done. Gonna upload a new version tomorrow.
Thiago Marcos P. Santos
Comment 6 2013-03-06 13:42:08 PST
Comment on attachment 191227 [details] Patch Removing flags. Going to rework this patch as suggested. Thanks for reviewing.
Benjamin Poulain
Comment 7 2013-03-06 13:55:34 PST
Thanks, I like the way this is going :)
Balazs Kelemen
Comment 8 2013-03-06 15:51:48 PST
(In reply to comment #4) > Why not create platform abstraction like PlatformWebView? This is exactly what I created bug 110978 for. I'm disappointed that we cannot add that abstraction to CoreIPC - which would make ports require less platform specific code to support concepts like network process or plugin process.
Benjamin Poulain
Comment 9 2013-03-06 16:03:36 PST
> This is exactly what I created bug 110978 for. I'm disappointed that we cannot add that abstraction to CoreIPC - which would make ports require less platform specific code to support concepts like network process or plugin process. This makes sense, I forgot about 110978. I would prefer 110978 being done prior to work on the tests.
Note You need to log in before you can comment on or make changes to this bug.