Bug 111303 - Remove redundant code in Document::updateHoverActiveState.
Summary: Remove redundant code in Document::updateHoverActiveState.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 05:11 PST by Mike West
Modified: 2013-03-05 01:18 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.73 KB, patch)
2013-03-04 05:15 PST, Mike West 		no flags Details | Formatted Diff | Diff
Patch for landing (2.81 KB, patch)
2013-03-05 00:27 PST, Mike West 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-03-04 05:11:26 PST 
Remove redundant code in Document::updateHoverActiveState.
Comment 1 Mike West 2013-03-04 05:15:33 PST 
Created attachment 191206 [details]
Patch
Comment 2 Mike West 2013-03-04 05:17:43 PST 
I've extracted this bit from carewolf's patch in bug 98168. It seems like a good idea to land this bit separately, as it's tangential to that larger patch's focus.
Comment 3 Mike West 2013-03-04 06:08:38 PST 
Comment on attachment 191206 [details]
Patch

FIXME: Credit carewolf in the ChangeLog before landing this.
Comment 4 Darin Adler 2013-03-04 15:02:35 PST 
Comment on attachment 191206 [details]
Patch

Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization.
Comment 5 Mike West 2013-03-05 00:27:16 PST 
(In reply to comment #4)
> (From update of attachment 191206 [details])
> Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization.

I believe the effect will be miniscule, but I'll keep an eye on perf.webkit.org just in case.

Thanks!
Comment 6 Mike West 2013-03-05 00:27:53 PST 
Created attachment 191419 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-03-05 01:18:03 PST 
Comment on attachment 191419 [details]
Patch for landing

Clearing flags on attachment: 191419

Committed r144741: <http://trac.webkit.org/changeset/144741>
Comment 8 WebKit Review Bot 2013-03-05 01:18:06 PST 
All reviewed patches have been landed.  Closing bug.