WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111303
Remove redundant code in Document::updateHoverActiveState.
https://bugs.webkit.org/show_bug.cgi?id=111303
Summary
Remove redundant code in Document::updateHoverActiveState.
Mike West
Reported
2013-03-04 05:11:26 PST
Remove redundant code in Document::updateHoverActiveState.
Attachments
Patch
(2.73 KB, patch)
2013-03-04 05:15 PST
,
Mike West
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.81 KB, patch)
2013-03-05 00:27 PST
,
Mike West
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mike West
Comment 1
2013-03-04 05:15:33 PST
Created
attachment 191206
[details]
Patch
Mike West
Comment 2
2013-03-04 05:17:43 PST
I've extracted this bit from carewolf's patch in
bug 98168
. It seems like a good idea to land this bit separately, as it's tangential to that larger patch's focus.
Mike West
Comment 3
2013-03-04 06:08:38 PST
Comment on
attachment 191206
[details]
Patch FIXME: Credit carewolf in the ChangeLog before landing this.
Darin Adler
Comment 4
2013-03-04 15:02:35 PST
Comment on
attachment 191206
[details]
Patch Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization.
Mike West
Comment 5
2013-03-05 00:27:16 PST
(In reply to
comment #4
)
> (From update of
attachment 191206
[details]
) > Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization.
I believe the effect will be miniscule, but I'll keep an eye on perf.webkit.org just in case. Thanks!
Mike West
Comment 6
2013-03-05 00:27:53 PST
Created
attachment 191419
[details]
Patch for landing
WebKit Review Bot
Comment 7
2013-03-05 01:18:03 PST
Comment on
attachment 191419
[details]
Patch for landing Clearing flags on attachment: 191419 Committed
r144741
: <
http://trac.webkit.org/changeset/144741
>
WebKit Review Bot
Comment 8
2013-03-05 01:18:06 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug