Bug 111297 - [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
Summary: [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 02:28 PST by Benjamin Poulain
Modified: 2013-03-08 12:42 PST (History)
21 users (show)

See Also:


Attachments
Patch (20.19 KB, patch)
2013-03-04 02:37 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (20.21 KB, patch)
2013-03-05 01:04 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (42.82 KB, patch)
2013-03-05 01:37 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (42.59 KB, patch)
2013-03-05 11:24 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (58.15 KB, patch)
2013-03-06 23:15 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-03-04 02:28:08 PST
[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
Comment 1 Benjamin Poulain 2013-03-04 02:37:42 PST
Created attachment 191183 [details]
Patch
Comment 2 Early Warning System Bot 2013-03-04 02:52:49 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16908530
Comment 3 Early Warning System Bot 2013-03-04 02:55:11 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16918067
Comment 4 WebKit Review Bot 2013-03-04 03:05:18 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16899797
Comment 5 EFL EWS Bot 2013-03-04 03:12:25 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16913338
Comment 6 WebKit Review Bot 2013-03-04 03:31:44 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16911452
Comment 7 Peter Beverloo (cr-android ews) 2013-03-04 16:55:32 PST
Comment on attachment 191183 [details]
Patch

Attachment 191183 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16851538
Comment 8 Benjamin Poulain 2013-03-05 01:04:07 PST
Created attachment 191426 [details]
Patch
Comment 9 Early Warning System Bot 2013-03-05 01:19:29 PST
Comment on attachment 191426 [details]
Patch

Attachment 191426 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17025056
Comment 10 Early Warning System Bot 2013-03-05 01:32:04 PST
Comment on attachment 191426 [details]
Patch

Attachment 191426 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17051020
Comment 11 Benjamin Poulain 2013-03-05 01:37:52 PST
Created attachment 191438 [details]
Patch
Comment 12 Benjamin Poulain 2013-03-05 01:51:54 PST
Damn it, build systems sucks :(
Comment 13 Benjamin Poulain 2013-03-05 11:24:40 PST
Created attachment 191521 [details]
Patch
Comment 14 Build Bot 2013-03-05 13:07:33 PST
Comment on attachment 191521 [details]
Patch

Attachment 191521 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17077001
Comment 15 Build Bot 2013-03-06 01:57:19 PST
Comment on attachment 191521 [details]
Patch

Attachment 191521 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17058023
Comment 16 Build Bot 2013-03-06 02:57:26 PST
Comment on attachment 191521 [details]
Patch

Attachment 191521 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17042233
Comment 17 Benjamin Poulain 2013-03-06 23:15:25 PST
Created attachment 191929 [details]
Patch
Comment 18 Benjamin Poulain 2013-03-08 12:42:06 PST
Comment on attachment 191929 [details]
Patch

Clearing flags on attachment: 191929

Committed r145255: <http://trac.webkit.org/changeset/145255>
Comment 19 Benjamin Poulain 2013-03-08 12:42:11 PST
All reviewed patches have been landed.  Closing bug.