Bug 111294 – Cleanup: Move HitTestLocation and HitTestResult into separate files.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mike West]

I noticed the FIXME while trying to understand some related code, so I might as well just take care of it; there's no good reason to keep HitTestLocation and HitTestResult in the same file.

[Mike West]

Created attachment 191177 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 191177 [details]
Patch

LGTM, pending on the builds bots clearing it.

[Mike West]

That was a shockingly fast review. Thanks. :)

[Early Warning System Bot]

Comment on attachment 191177 [details]
Patch

Attachment 191177 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16910526

[Early Warning System Bot]

Comment on attachment 191177 [details]
Patch

Attachment 191177 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16917158

[Mike West]

Created attachment 191212 [details]
Patch

[Mike West]

(In reply to comment #6)
> Created an attachment (id=191212) [details]
> Patch

Ossy pointed me in the right direction regarding Qt (thanks!). If it passes the bots this time, I'll CQ it.

[WebKit Review Bot]

Comment on attachment 191212 [details]
Patch

Attachment 191212 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16917248

[Build Bot]

Comment on attachment 191212 [details]
Patch

Attachment 191212 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16917246

[Early Warning System Bot]

Comment on attachment 191212 [details]
Patch

Attachment 191212 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16912517

[EFL EWS Bot]

Comment on attachment 191212 [details]
Patch

Attachment 191212 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16916284

[Early Warning System Bot]

Comment on attachment 191212 [details]
Patch

Attachment 191212 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16898871

[Mike West]

(In reply to comment #12)
> (From update of attachment 191212 [details])
> Attachment 191212 [details] did not pass qt-wk2-ews (qt):
> Output: http://webkit-commit-queue.appspot.com/results/16898871

*sigh* Today is not my day. I'll upload a new patch in a moment. One that actually includes the files I'm adding. :(

[Mike West]

Created attachment 191220 [details]
Patch

[Mike West]

Comment on attachment 191220 [details]
Patch

Bots are happy. CQing.

[WebKit Review Bot]

Comment on attachment 191220 [details]
Patch

Rejecting attachment 191220 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 191220, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/rendering/HitTestLocation.cpp
patching file Source/WebCore/rendering/HitTestLocation.h
patching file Source/WebCore/rendering/HitTestResult.cpp
patching file Source/WebCore/rendering/HitTestResult.h
patching file Source/WebCore/rendering/RenderBlock.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/17050011

[Mike West]

Created attachment 191436 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 191436 [details]
Patch for landing

Clearing flags on attachment: 191436

Committed r144743: <http://trac.webkit.org/changeset/144743>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.