Bug 111291 - [EFL] Build fix when compiling with GLES2 support enabled.
Summary: [EFL] Build fix when compiling with GLES2 support enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Kalyan
URL:
Keywords:
Depends on:
Blocks: 105659
  Show dependency tree / graph
 
Reported: 2013-03-04 00:59 PST by Kalyan
Modified: 2013-03-04 05:09 PST (History)
7 users (show)

See Also:

Attachments
patch (2.81 KB, patch)
2013-03-04 02:14 PST, Kalyan 		kenneth: review+
Details | Formatted Diff | Diff
patchv2 (2.84 KB, patch)
2013-03-04 03:48 PST, Kalyan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalyan 2013-03-04 00:59:28 PST 
Some changes are needed to be able to build successfully with EGL+GLES2 enabled. 
1)Add support for GLES2 in SnapShotImageGL.
2)Remove the workarounds in place for EGL support with GLX as the main target for EGL is with GLES2.
3)Add platform checks in TextureMapper and OpenGLESShims.h

This patch targets 2 and 3. 1 would be handled in a separate bug.
Comment 1 Kalyan 2013-03-04 02:14:51 PST 
Created attachment 191179 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2013-03-04 02:30:29 PST 
Comment on attachment 191179 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191179&action=review

> Source/WebCore/platform/graphics/opengl/GLPlatformContext.cpp:-41
> -#if HAVE(GLX)
> -#include <GL/glx.h>
> -#endif

so I assume this was an evas specific work around? maybe clearify that in the changelog
Comment 3 Kalyan 2013-03-04 03:48:47 PST 
Created attachment 191196 [details]
patchv2
Comment 4 Kalyan 2013-03-04 03:49:14 PST 
(In reply to comment #2)
> (From update of attachment 191179 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191179&action=review
> 
> so I assume this was an evas specific work around? maybe clearify that in the changelog

done
Comment 5 WebKit Review Bot 2013-03-04 05:09:52 PST 
Comment on attachment 191196 [details]
patchv2

Clearing flags on attachment: 191196

Committed r144620: <http://trac.webkit.org/changeset/144620>
Comment 6 WebKit Review Bot 2013-03-04 05:09:56 PST 
All reviewed patches have been landed.  Closing bug.