Bug 111285 - [chromium] Switch to new webkit_support::CreateLayerTreeView interface
Summary: [chromium] Switch to new webkit_support::CreateLayerTreeView interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-03 22:35 PST by James Robinson
Modified: 2013-03-05 10:21 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.65 KB, patch)
2013-03-03 22:36 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-03-03 22:35:51 PST
[chromium] Switch to new webkit_support::CreateLayerTreeView interface
Comment 1 James Robinson 2013-03-03 22:36:46 PST
Created attachment 191162 [details]
Patch
Comment 2 James Robinson 2013-03-03 22:37:13 PST
Depends on https://codereview.chromium.org/12385074/ landing + rolling in.
Comment 3 WebKit Review Bot 2013-03-03 22:48:02 PST
Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16913258
Comment 4 WebKit Review Bot 2013-03-03 22:56:25 PST
Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16892980
Comment 5 Adrienne Walker 2013-03-04 11:47:23 PST
Comment on attachment 191162 [details]
Patch

R=me.
Comment 6 Peter Beverloo (cr-android ews) 2013-03-04 12:57:08 PST
Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16897018
Comment 7 James Robinson 2013-03-04 14:24:47 PST
Comment on attachment 191162 [details]
Patch

API has rolled in now
Comment 8 WebKit Review Bot 2013-03-04 18:36:29 PST
Comment on attachment 191162 [details]
Patch

Clearing flags on attachment: 191162

Committed r144705: <http://trac.webkit.org/changeset/144705>
Comment 9 WebKit Review Bot 2013-03-04 18:36:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Takashi Sakamoto 2013-03-05 00:59:30 PST
Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.

75      void WebCompositorSupportImpl::shutdown() {
76        DCHECK(initialized_);
77        initialized_ = false;
78        compositor_thread_message_loop_proxy_ = NULL;
79      }

So, core dumped.

[18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
 [0x000002735eb4] base::debug::StackTrace::StackTrace()
 [0x0000027511fd] logging::LogMessage::~LogMessage()
 [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
 [0x000000420244] main
 [0x7ffff394376d] __libc_start_main
 [0x00000041dc29] <unknown>
Comment 11 James Robinson 2013-03-05 10:15:03 PST
(In reply to comment #10)
> Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.
> 
> 75      void WebCompositorSupportImpl::shutdown() {
> 76        DCHECK(initialized_);
> 77        initialized_ = false;
> 78        compositor_thread_message_loop_proxy_ = NULL;
> 79      }
> 
> So, core dumped.
> 
> [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
>  [0x000002735eb4] base::debug::StackTrace::StackTrace()
>  [0x0000027511fd] logging::LogMessage::~LogMessage()
>  [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
>  [0x000000420244] main
>  [0x7ffff394376d] __libc_start_main
>  [0x00000041dc29] <unknown>

D'oh.  It's a silly assert, but lives on the chromium side.  Will remove there.
Comment 12 James Robinson 2013-03-05 10:21:08 PST
(In reply to comment #11)
> (In reply to comment #10)
> > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.
> > 
> > 75      void WebCompositorSupportImpl::shutdown() {
> > 76        DCHECK(initialized_);
> > 77        initialized_ = false;
> > 78        compositor_thread_message_loop_proxy_ = NULL;
> > 79      }
> > 
> > So, core dumped.
> > 
> > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
> >  [0x000002735eb4] base::debug::StackTrace::StackTrace()
> >  [0x0000027511fd] logging::LogMessage::~LogMessage()
> >  [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
> >  [0x000000420244] main
> >  [0x7ffff394376d] __libc_start_main
> >  [0x00000041dc29] <unknown>
> 
> D'oh.  It's a silly assert, but lives on the chromium side.  Will remove there.
https://bugs.webkit.org/show_bug.cgi?id=111440