Bug 111285 – [chromium] Switch to new webkit_support::CreateLayerTreeView interface

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Switch to new webkit_support::CreateLayerTreeView interface

[James Robinson]

Created attachment 191162 [details]
Patch

[James Robinson]

Depends on https://codereview.chromium.org/12385074/ landing + rolling in.

[WebKit Review Bot]

Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16913258

[WebKit Review Bot]

Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16892980

[Adrienne Walker]

Comment on attachment 191162 [details]
Patch

R=me.

[Peter Beverloo (cr-android ews)]

Comment on attachment 191162 [details]
Patch

Attachment 191162 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16897018

[James Robinson]

Comment on attachment 191162 [details]
Patch

API has rolled in now

[WebKit Review Bot]

Comment on attachment 191162 [details]
Patch

Clearing flags on attachment: 191162

Committed r144705: <http://trac.webkit.org/changeset/144705>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Takashi Sakamoto]

Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.

75      void WebCompositorSupportImpl::shutdown() {
76        DCHECK(initialized_);
77        initialized_ = false;
78        compositor_thread_message_loop_proxy_ = NULL;
79      }

So, core dumped.

[18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
 [0x000002735eb4] base::debug::StackTrace::StackTrace()
 [0x0000027511fd] logging::LogMessage::~LogMessage()
 [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
 [0x000000420244] main
 [0x7ffff394376d] __libc_start_main
 [0x00000041dc29] <unknown>

[James Robinson]

(In reply to comment #10)
> Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.
> 
> 75      void WebCompositorSupportImpl::shutdown() {
> 76        DCHECK(initialized_);
> 77        initialized_ = false;
> 78        compositor_thread_message_loop_proxy_ = NULL;
> 79      }
> 
> So, core dumped.
> 
> [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
>  [0x000002735eb4] base::debug::StackTrace::StackTrace()
>  [0x0000027511fd] logging::LogMessage::~LogMessage()
>  [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
>  [0x000000420244] main
>  [0x7ffff394376d] __libc_start_main
>  [0x00000041dc29] <unknown>

D'oh.  It's a silly assert, but lives on the chromium side.  Will remove there.

[James Robinson]

(In reply to comment #11)
> (In reply to comment #10)
> > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails.
> > 
> > 75      void WebCompositorSupportImpl::shutdown() {
> > 76        DCHECK(initialized_);
> > 77        initialized_ = false;
> > 78        compositor_thread_message_loop_proxy_ = NULL;
> > 79      }
> > 
> > So, core dumped.
> > 
> > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. 
> >  [0x000002735eb4] base::debug::StackTrace::StackTrace()
> >  [0x0000027511fd] logging::LogMessage::~LogMessage()
> >  [0x000002600963] webkit::WebCompositorSupportImpl::shutdown()
> >  [0x000000420244] main
> >  [0x7ffff394376d] __libc_start_main
> >  [0x00000041dc29] <unknown>
> 
> D'oh.  It's a silly assert, but lives on the chromium side.  Will remove there.
https://bugs.webkit.org/show_bug.cgi?id=111440