[chromium] Switch to new webkit_support::CreateLayerTreeView interface
Created attachment 191162 [details] Patch
Depends on https://codereview.chromium.org/12385074/ landing + rolling in.
Comment on attachment 191162 [details] Patch Attachment 191162 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16913258
Comment on attachment 191162 [details] Patch Attachment 191162 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16892980
Comment on attachment 191162 [details] Patch R=me.
Comment on attachment 191162 [details] Patch Attachment 191162 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16897018
Comment on attachment 191162 [details] Patch API has rolled in now
Comment on attachment 191162 [details] Patch Clearing flags on attachment: 191162 Committed r144705: <http://trac.webkit.org/changeset/144705>
All reviewed patches have been landed. Closing bug.
Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. 75 void WebCompositorSupportImpl::shutdown() { 76 DCHECK(initialized_); 77 initialized_ = false; 78 compositor_thread_message_loop_proxy_ = NULL; 79 } So, core dumped. [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. [0x000002735eb4] base::debug::StackTrace::StackTrace() [0x0000027511fd] logging::LogMessage::~LogMessage() [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() [0x000000420244] main [0x7ffff394376d] __libc_start_main [0x00000041dc29] <unknown>
(In reply to comment #10) > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. > > 75 void WebCompositorSupportImpl::shutdown() { > 76 DCHECK(initialized_); > 77 initialized_ = false; > 78 compositor_thread_message_loop_proxy_ = NULL; > 79 } > > So, core dumped. > > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. > [0x000002735eb4] base::debug::StackTrace::StackTrace() > [0x0000027511fd] logging::LogMessage::~LogMessage() > [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() > [0x000000420244] main > [0x7ffff394376d] __libc_start_main > [0x00000041dc29] <unknown> D'oh. It's a silly assert, but lives on the chromium side. Will remove there.
(In reply to comment #11) > (In reply to comment #10) > > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. > > > > 75 void WebCompositorSupportImpl::shutdown() { > > 76 DCHECK(initialized_); > > 77 initialized_ = false; > > 78 compositor_thread_message_loop_proxy_ = NULL; > > 79 } > > > > So, core dumped. > > > > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. > > [0x000002735eb4] base::debug::StackTrace::StackTrace() > > [0x0000027511fd] logging::LogMessage::~LogMessage() > > [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() > > [0x000000420244] main > > [0x7ffff394376d] __libc_start_main > > [0x00000041dc29] <unknown> > > D'oh. It's a silly assert, but lives on the chromium side. Will remove there. https://bugs.webkit.org/show_bug.cgi?id=111440