Bug 111272 - Attempt to fix the Qt build after r144498
Summary: Attempt to fix the Qt build after r144498
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Blocks: 106127
  Show dependency treegraph
Reported: 2013-03-03 10:18 PST by Adam Barth
Modified: 2013-03-03 12:20 PST (History)
3 users (show)

See Also:

Patch (1.81 KB, patch)
2013-03-03 10:20 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-03-03 10:18:09 PST
Attempt to fix the Qt build after r144498
Comment 1 Adam Barth 2013-03-03 10:20:36 PST
Created attachment 191137 [details]
Comment 2 Eric Seidel (no email) 2013-03-03 10:27:27 PST
Comment on attachment 191137 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=191137&action=review

> Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:276
> +    append(String("<qxmlstreamdummyelement>").impl());

This could be StringImpl::create(), but this is also fine.
Comment 3 Adam Barth 2013-03-03 10:30:42 PST
I'm going to leave it that way for simplicity.
Comment 4 WebKit Review Bot 2013-03-03 11:59:39 PST
Comment on attachment 191137 [details]

Clearing flags on attachment: 191137

Committed r144578: <http://trac.webkit.org/changeset/144578>
Comment 5 WebKit Review Bot 2013-03-03 11:59:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Julien Brianceau 2013-03-03 12:20:26 PST
(In reply to comment #0)
> Attempt to fix the Qt build after r144498
Build is ok now: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/21413

Thanks a lot for your reactivity (even on a sunday) !