RESOLVED FIXED 111266
REGRESSION(r144567): Does not compile on apple-win (Requested by abarth on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=111266
Summary REGRESSION(r144567): Does not compile on apple-win (Requested by abarth on #w...
WebKit Review Bot
Reported 2013-03-03 02:29:41 PST
http://trac.webkit.org/changeset/144567 broke the build: Does not compile on apple-win (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r144567 (24.07 KB, patch)
2013-03-03 02:30 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2013-03-03 02:30:18 PST
Created attachment 191132 [details] ROLLOUT of r144567 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Ryosuke Niwa
Comment 2 2013-03-03 02:32:13 PST
Comment on attachment 191132 [details] ROLLOUT of r144567 I’ll try my fix first.
Ryosuke Niwa
Comment 3 2013-03-03 03:42:21 PST
Comment on attachment 191132 [details] ROLLOUT of r144567 I’ve tried several build fixes including clean builds but that didn’t help: 19> Creating library C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\DumpRenderTree.lib and object C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\lib\DumpRenderTree.exp 19>WebCoreTestSupport.lib(JSInternals.obj) : error LNK2019: unresolved external symbol "class JSC::JSValue __cdecl WebCore::toJS(class JSC::ExecState *,class WebCore::JSDOMGlobalObject *,class WebCore::CSSStyleDeclaration *)" (?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVCSSStyleDeclaration@1@@Z) referenced in function "__int64 __fastcall WebCore::jsInternalsPrototypeFunctionComputedStyleIncludingVisitedInfo(class JSC::ExecState *)" (?jsInternalsPrototypeFunctionComputedStyleIncludingVisitedInfo@WebCore@@YI_JPAVExecState@JSC@@@Z) 19>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\DumpRenderTree.dll : fatal error LNK1120: 1 unresolved externals
WebKit Review Bot
Comment 4 2013-03-03 03:49:47 PST
Comment on attachment 191132 [details] ROLLOUT of r144567 Clearing flags on attachment: 191132 Committed r144572: <http://trac.webkit.org/changeset/144572>
WebKit Review Bot
Comment 5 2013-03-03 03:49:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.