Bug 111258 - PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication
Summary: PDFPlugin: Rename delegate method from openWithPreview to openWithNativeAppli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-02 17:03 PST by Tim Horton
Modified: 2013-03-03 23:11 PST (History)
1 user (show)

See Also:

Attachments
patch (2.04 KB, patch)
2013-03-02 17:05 PST, Tim Horton 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-03-02 17:03:47 PST 
Because that's more accurate!
Comment 1 Tim Horton 2013-03-02 17:05:28 PST 
Created attachment 191121 [details]
patch
Comment 2 Alexey Proskuryakov 2013-03-02 18:28:33 PST 
Comment on attachment 191121 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review

r=me assuming there is a good answer to the question below.

> Source/WebKit2/ChangeLog:11
> +        Rename from openWithPreview to openWithNativeApplication for accuracy.

I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate.

Did PDFLayerController change? If it did, do we need to support both names for the time being?
Comment 3 Tim Horton 2013-03-02 18:30:02 PST 
(In reply to comment #2)
> (From update of attachment 191121 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review
> 
> r=me assuming there is a good answer to the question below.
> 
> > Source/WebKit2/ChangeLog:11
> > +        Rename from openWithPreview to openWithNativeApplication for accuracy.
> 
> I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate.
> 
> Did PDFLayerController change? If it did, do we need to support both names for the time being?

Yes, it changed, long ago. It sends whichever the delegate implements.
Comment 4 Tim Horton 2013-03-03 23:11:26 PST 
http://trac.webkit.org/changeset/144599