RESOLVED FIXED 111258
PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication 
https://bugs.webkit.org/show_bug.cgi?id=111258
Summary PDFPlugin: Rename delegate method from openWithPreview to openWithNativeAppli...
Tim Horton
Reported 2013-03-02 17:03:47 PST
Because that's more accurate!
Attachments
patch (2.04 KB, patch)
2013-03-02 17:05 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-03-02 17:05:28 PST
Created attachment 191121 [details] patch
Alexey Proskuryakov
Comment 2 2013-03-02 18:28:33 PST
Comment on attachment 191121 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review r=me assuming there is a good answer to the question below. > Source/WebKit2/ChangeLog:11 > + Rename from openWithPreview to openWithNativeApplication for accuracy. I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. Did PDFLayerController change? If it did, do we need to support both names for the time being?
Tim Horton
Comment 3 2013-03-02 18:30:02 PST
(In reply to comment #2) > (From update of attachment 191121 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review > > r=me assuming there is a good answer to the question below. > > > Source/WebKit2/ChangeLog:11 > > + Rename from openWithPreview to openWithNativeApplication for accuracy. > > I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. > > Did PDFLayerController change? If it did, do we need to support both names for the time being? Yes, it changed, long ago. It sends whichever the delegate implements.
Tim Horton
Comment 4 2013-03-03 23:11:26 PST
http://trac.webkit.org/changeset/144599
Note You need to log in before you can comment on or make changes to this bug.