RESOLVED FIXED Bug 111251
Web Inspector: remove existing LayerTreeAgent protocol APIs 
https://bugs.webkit.org/show_bug.cgi?id=111251
Summary Web Inspector: remove existing LayerTreeAgent protocol APIs
Antoine Quint
Reported 2013-03-02 07:31:57 PST
In preparation for https://bugs.webkit.org/show_bug.cgi?id=110407 and the series of patches needed to address it, we should start by cleaning up the existing getLayerTree() and nodeIdForLayerId() APIs exposed by the LayerTreeAgent. This will make further patches easier to read.
Attachments
Patch (35.29 KB, patch)
2013-03-02 07:36 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-03-02 07:32:15 PST
<rdar://problem/13331811>
Antoine Quint
Comment 2 2013-03-02 07:36:30 PST
Created attachment 191106 [details] Patch
WebKit Review Bot
Comment 3 2013-03-04 06:09:57 PST
Comment on attachment 191106 [details] Patch Clearing flags on attachment: 191106 Committed r144624: <http://trac.webkit.org/changeset/144624>
WebKit Review Bot
Comment 4 2013-03-04 06:10:00 PST
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 5 2013-03-04 07:34:52 PST
Did this cause In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36: /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field] Page* m_inspectedPage; ^ 1 error generated. XCode 4.6.x?
Antoine Quint
Comment 6 2013-03-04 07:46:08 PST
(In reply to comment #5) > Did this cause > > In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36: > /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field] > Page* m_inspectedPage; > ^ > 1 error generated. > > > XCode 4.6.x? Probably, I'm looking into it right now.
Antoine Quint
Comment 7 2013-03-04 08:26:49 PST
(In reply to comment #6) > (In reply to comment #5) > > Did this cause > > > > In file included from /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:36: > > /Users/a1.gomes/Devel/Samsung/webkit/Source/WebCore/inspector/InspectorLayerTreeAgent.h:81:11: error: private field 'm_inspectedPage' is not used [-Werror,-Wunused-private-field] > > Page* m_inspectedPage; > > ^ > > 1 error generated. > > > > > > XCode 4.6.x? > > Probably, I'm looking into it right now. Fix went in http://trac.webkit.org/changeset/144631.
Note You need to log in before you can comment on or make changes to this bug.