http://trac.webkit.org/changeset/131131 seems to have broken http://www.google.com/insidesearch/howsearchworks/thestory/
The page loads, but the animations don't start.
firstname.lastname@example.org, do you plan to look at this?
Iirw, we tweaked that patch such that webkitRequestAnimFrame delivers a DOMTimestamp [old style] and the unprefixed requestAnimationFrame delivers a DOMHighResolutionTimestamp. @simonjam can confirm...
We'd love to take out the old behavior though. We should track down whoever owns that and ask them to update.
(In reply to comment #4)
> Exactly right.
> We'd love to take out the old behavior though. We should track down whoever owns that and ask them to update.
Are you saying that r139509 should have fixed this bug, too? It still looks broken to me in ToT.
It looks like r139509 won't help here. This site has a proper polyfill, so it should pick up the unprefixed requestAnimationFrame() first, which is based on performance.now() values.
Does ToT have window.performance.now() defined? Without that, it'd definitely be broken.
If that's the case, we need to either enable performance.now(), or disable requestAnimationFrame() and only provide webkitRequestAnimationFrame() if now() isn't available.
Created attachment 199877 [details]
Comment on attachment 199877 [details]
Created attachment 200004 [details]
Comment on attachment 200004 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=200004&action=review
r=me, but consider the feedback.
> +ENABLE_WEB_TIMING_MINIMAL = ENABLE_WEB_TIMING_MINIMAL;
> ENABLE_WEB_TIMING = ;
Nit: I would put ENABLE_WEB_TIMING_MINIMAL after ENABLE_WEB_TIMING (to match FEATURE_DEFINES below). If you change this, please remember to make the same change to all FeatureDefines.xcconfig files.
> +#if !defined(ENABLE_WEB_TIMING_MINIMAL)
> +#define ENABLE_WEB_TIMING_MINIMAL 0
> #if !defined(ENABLE_WEB_TIMING)
> #define ENABLE_WEB_TIMING 0
Should we add an #error if both WEB_TIMING and WEB_TIMING_MINIMAL are enabled?
Nit: I would reverse the order of these as well.
Created attachment 200090 [details]
Comment on attachment 200090 [details]
Clearing flags on attachment: 200090
Committed r149359: <http://trac.webkit.org/changeset/149359>
All reviewed patches have been landed. Closing bug.
Re-opening since most of this change was rolled out for Bug 115601 in r149999: