WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
111244
Animations fail to start on
http://www.google.com/insidesearch/howsearchworks/thestory/
https://bugs.webkit.org/show_bug.cgi?id=111244
Summary
Animations fail to start on http://www.google.com/insidesearch/howsearchworks...
Simon Fraser (smfr)
Reported
2013-03-01 23:10:53 PST
http://trac.webkit.org/changeset/131131
seems to have broken
http://www.google.com/insidesearch/howsearchworks/thestory/
The page loads, but the animations don't start.
Attachments
Patch
(40.00 KB, patch)
2013-04-26 17:13 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(43.81 KB, patch)
2013-04-29 07:11 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(43.92 KB, patch)
2013-04-30 01:39 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2013-03-01 23:11:08 PST
<
rdar://problem/13330885
>
Simon Fraser (smfr)
Comment 2
2013-03-15 09:21:05 PDT
nduca@chromium.org
, do you plan to look at this?
Nat Duca
Comment 3
2013-03-18 17:06:43 PDT
Iirw, we tweaked that patch such that webkitRequestAnimFrame delivers a DOMTimestamp [old style] and the unprefixed requestAnimationFrame delivers a DOMHighResolutionTimestamp. @simonjam can confirm...
James Simonsen
Comment 4
2013-03-18 17:15:41 PDT
Exactly right.
https://bugs.webkit.org/show_bug.cgi?id=106697
We'd love to take out the old behavior though. We should track down whoever owns that and ask them to update.
Andy Estes
Comment 5
2013-03-19 14:09:55 PDT
(In reply to
comment #4
)
> Exactly right. > >
https://bugs.webkit.org/show_bug.cgi?id=106697
> > We'd love to take out the old behavior though. We should track down whoever owns that and ask them to update.
Are you saying that
r139509
should have fixed this bug, too? It still looks broken to me in ToT.
James Simonsen
Comment 6
2013-03-19 15:06:36 PDT
It looks like
r139509
won't help here. This site has a proper polyfill, so it should pick up the unprefixed requestAnimationFrame() first, which is based on performance.now() values. Does ToT have window.performance.now() defined? Without that, it'd definitely be broken. If that's the case, we need to either enable performance.now(), or disable requestAnimationFrame() and only provide webkitRequestAnimationFrame() if now() isn't available.
zalan
Comment 7
2013-04-26 17:13:42 PDT
Created
attachment 199877
[details]
Patch
zalan
Comment 8
2013-04-27 09:56:52 PDT
Comment on
attachment 199877
[details]
Patch missing testcase
zalan
Comment 9
2013-04-29 07:11:48 PDT
Created
attachment 200004
[details]
Patch
David Kilzer (:ddkilzer)
Comment 10
2013-04-29 14:47:26 PDT
Comment on
attachment 200004
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=200004&action=review
r=me, but consider the feedback.
> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:183 > +ENABLE_WEB_TIMING_MINIMAL = ENABLE_WEB_TIMING_MINIMAL; > ENABLE_WEB_TIMING = ;
Nit: I would put ENABLE_WEB_TIMING_MINIMAL after ENABLE_WEB_TIMING (to match FEATURE_DEFINES below). If you change this, please remember to make the same change to all FeatureDefines.xcconfig files.
> Source/WTF/wtf/FeatureDefines.h:825 > +#if !defined(ENABLE_WEB_TIMING_MINIMAL) > +#define ENABLE_WEB_TIMING_MINIMAL 0 > +#endif > + > #if !defined(ENABLE_WEB_TIMING) > #define ENABLE_WEB_TIMING 0 > #endif
Should we add an #error if both WEB_TIMING and WEB_TIMING_MINIMAL are enabled? Nit: I would reverse the order of these as well.
zalan
Comment 11
2013-04-30 01:39:03 PDT
Created
attachment 200090
[details]
Patch
WebKit Commit Bot
Comment 12
2013-04-30 03:53:10 PDT
Comment on
attachment 200090
[details]
Patch Clearing flags on attachment: 200090 Committed
r149359
: <
http://trac.webkit.org/changeset/149359
>
WebKit Commit Bot
Comment 13
2013-04-30 03:53:12 PDT
All reviewed patches have been landed. Closing bug.
David Kilzer (:ddkilzer)
Comment 14
2013-07-21 08:46:04 PDT
Re-opening since most of this change was rolled out for
Bug 115601
in
r149999
: <
http://trac.webkit.org/changeset/149999
>
Ahmad Saleem
Comment 15
2024-04-11 07:01:21 PDT
Seems to work fine now.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug