Bug 111229 - Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
Summary: Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 15:55 PST by Min Qin
Modified: 2013-03-04 15:02 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2013-03-01 16:04 PST, Min Qin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Min Qin 2013-03-01 15:55:48 PST
Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
Comment 1 Min Qin 2013-03-01 16:04:29 PST
Created attachment 191060 [details]
Patch
Comment 2 Xianzhu Wang 2013-03-04 10:21:14 PST
Comment on attachment 191060 [details]
Patch

CQ+ per Min's request.
Comment 3 WebKit Review Bot 2013-03-04 10:25:19 PST
Comment on attachment 191060 [details]
Patch

Clearing flags on attachment: 191060

Committed r144642: <http://trac.webkit.org/changeset/144642>
Comment 4 WebKit Review Bot 2013-03-04 10:25:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-03-04 14:32:41 PST
Comment on attachment 191060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191060&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:787
> +    if (Settings* settings = m_renderView->document()->settings())
> +        if (!settings->applyPageScaleFactorInCompositor())
> +            clipRect.scale(pageScaleFactor());

WebKit coding style requires braces around the body of the outer if since the inner if is two lines long.
Comment 6 Min Qin 2013-03-04 15:02:16 PST
(In reply to comment #5)
> (From update of attachment 191060 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191060&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.cpp:787
> > +    if (Settings* settings = m_renderView->document()->settings())
> > +        if (!settings->applyPageScaleFactorInCompositor())
> > +            clipRect.scale(pageScaleFactor());
> 
> WebKit coding style requires braces around the body of the outer if since the inner if is two lines long.

hmm... this file seems to have the same style error in another place. will fix both in a separate patch.