Bug 111226 - [BlackBerry] Upstream smart selection
Summary: [BlackBerry] Upstream smart selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 14:59 PST by Iris Wu
Modified: 2013-05-01 18:08 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.68 KB, patch)
2013-03-01 15:15 PST, Iris Wu 		rwlbuis: review-
Details | Formatted Diff | Diff
Patch with Changelog (22.13 KB, patch)
2013-03-01 15:19 PST, Iris Wu 		no flags Details | Formatted Diff | Diff
Patch with Changelog (22.10 KB, patch)
2013-03-01 15:43 PST, Iris Wu 		no flags Details | Formatted Diff | Diff
Patch with ChangeLog (9.36 KB, patch)
2013-04-30 15:22 PDT, Iris Wu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iris Wu 2013-03-01 14:59:58 PST 
Upstream selection expansion api and methods.
Selection expands from word, sentence, paragraph to next paragraph.
Scroll page if needed.
Comment 1 Iris Wu 2013-03-01 15:15:46 PST 
Created attachment 191050 [details]
Patch
Comment 2 Rob Buis 2013-03-01 15:17:31 PST 
Comment on attachment 191050 [details]
Patch

Need ChangeLog
Comment 3 Iris Wu 2013-03-01 15:19:43 PST 
Created attachment 191051 [details]
Patch with Changelog
Comment 4 Iris Wu 2013-03-01 15:43:30 PST 
Created attachment 191054 [details]
Patch with Changelog
Comment 5 Rob Buis 2013-03-01 15:51:12 PST 
Comment on attachment 191054 [details]
Patch with Changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=191054&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:773
> +        m_webPage->client()->animateBlockZoom(m_webPage->m_webPage->currentScale(), m_webPage->m_finalBlockPoint);

We need to fix this old code, see webkit/8b9c47ddd226bbbaea21cb14d7b3e0a8c8e56b20. We can do that in a later patch though.
Comment 6 WebKit Review Bot 2013-03-01 17:02:50 PST 
Comment on attachment 191054 [details]
Patch with Changelog

Rejecting attachment 191054 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191054, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13779 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
54>At revision 13779.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/16687609
Comment 7 WebKit Review Bot 2013-03-01 17:02:59 PST 
Comment on attachment 191054 [details]
Patch with Changelog

Clearing flags on attachment: 191054

Committed r144515: <http://trac.webkit.org/changeset/144515>
Comment 8 WebKit Review Bot 2013-03-01 17:03:03 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Iris Wu 2013-04-30 15:22:29 PDT 
Created attachment 200186 [details]
Patch with ChangeLog
Comment 10 Iris Wu 2013-04-30 15:22:54 PDT 
New patch added
Comment 11 Rob Buis 2013-05-01 17:41:01 PDT 
Comment on attachment 200186 [details]
Patch with ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=200186&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:4
> +         https://bugs.webkit.org/show_bug.cgi?id=111226

Slight indentation fault.
Comment 12 WebKit Commit Bot 2013-05-01 18:08:25 PDT 
Comment on attachment 200186 [details]
Patch with ChangeLog

Clearing flags on attachment: 200186

Committed r149471: <http://trac.webkit.org/changeset/149471>
Comment 13 WebKit Commit Bot 2013-05-01 18:08:29 PDT 
All reviewed patches have been landed.  Closing bug.