Bug 111226 – [BlackBerry] Upstream smart selection

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Iris Wu]

Upstream selection expansion api and methods.
Selection expands from word, sentence, paragraph to next paragraph.
Scroll page if needed.

[Iris Wu]

Created attachment 191050 [details]
Patch

[Rob Buis]

Comment on attachment 191050 [details]
Patch

Need ChangeLog

[Iris Wu]

Created attachment 191051 [details]
Patch with Changelog

[Iris Wu]

Created attachment 191054 [details]
Patch with Changelog

[Rob Buis]

Comment on attachment 191054 [details]
Patch with Changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=191054&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:773
> +        m_webPage->client()->animateBlockZoom(m_webPage->m_webPage->currentScale(), m_webPage->m_finalBlockPoint);

We need to fix this old code, see webkit/8b9c47ddd226bbbaea21cb14d7b3e0a8c8e56b20. We can do that in a later patch though.

[WebKit Review Bot]

Comment on attachment 191054 [details]
Patch with Changelog

Rejecting attachment 191054 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191054, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13779 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
54>At revision 13779.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/16687609

[WebKit Review Bot]

Comment on attachment 191054 [details]
Patch with Changelog

Clearing flags on attachment: 191054

Committed r144515: <http://trac.webkit.org/changeset/144515>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Iris Wu]

Created attachment 200186 [details]
Patch with ChangeLog

[Iris Wu]

New patch added

[Rob Buis]

Comment on attachment 200186 [details]
Patch with ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=200186&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:4
> +         https://bugs.webkit.org/show_bug.cgi?id=111226

Slight indentation fault.

[WebKit Commit Bot]

Comment on attachment 200186 [details]
Patch with ChangeLog

Clearing flags on attachment: 200186

Committed r149471: <http://trac.webkit.org/changeset/149471>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.