Bug 111223 - [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
Summary: [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 14:43 PST by Kentaro Hara
Modified: 2013-03-03 16:00 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.59 KB, patch)
2013-03-01 14:45 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-03-01 14:43:55 PST
HTMLDocument::getNamedProperty() is used by DOMWindowShell. It can be a static method in DOMWindowShell.
Comment 1 Kentaro Hara 2013-03-01 14:45:01 PST
Created attachment 191039 [details]
Patch
Comment 2 Adam Barth 2013-03-02 23:20:45 PST
Comment on attachment 191039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review

> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435
> +        return v8Undefined();

Should we pass the isolate to v8Undefined ?
Comment 3 Kentaro Hara 2013-03-03 15:54:44 PST
Committed r144584: <http://trac.webkit.org/changeset/144584>
Comment 4 Kentaro Hara 2013-03-03 16:00:51 PST
(In reply to comment #2)
> (From update of attachment 191039 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review
> 
> > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435
> > +        return v8Undefined();
> 
> Should we pass the isolate to v8Undefined ?

I have to fix it when I fix bug 104088. Currently v8::Undefined(), v8Undefined() and Handle<Value>() are mixed inconsistently.