RESOLVED FIXED 111223
[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell 
https://bugs.webkit.org/show_bug.cgi?id=111223
Summary [V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
Kentaro Hara
Reported 2013-03-01 14:43:55 PST
HTMLDocument::getNamedProperty() is used by DOMWindowShell. It can be a static method in DOMWindowShell.
Attachments
Patch (5.59 KB, patch)
2013-03-01 14:45 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-03-01 14:45:01 PST
Created attachment 191039 [details] Patch
Adam Barth
Comment 2 2013-03-02 23:20:45 PST
Comment on attachment 191039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > + return v8Undefined(); Should we pass the isolate to v8Undefined ?
Kentaro Hara
Comment 3 2013-03-03 15:54:44 PST
Committed r144584: <http://trac.webkit.org/changeset/144584>
Kentaro Hara
Comment 4 2013-03-03 16:00:51 PST
(In reply to comment #2) > (From update of attachment 191039 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191039&action=review > > > Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:435 > > + return v8Undefined(); > > Should we pass the isolate to v8Undefined ? I have to fix it when I fix bug 104088. Currently v8::Undefined(), v8Undefined() and Handle<Value>() are mixed inconsistently.
Note You need to log in before you can comment on or make changes to this bug.