Bug 111222 – AX: aria-label does not override text content on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

iOS needs to use the text alternative computation rules already being used by the Mac

[chris fleizach]

Created attachment 191046 [details]
patch

[David Kilzer (:ddkilzer)]

Comment on attachment 191046 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191046&action=review

r=me, but consider expanding the layout test to cover all four scenarios if possible.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:685
> +    if ([axTitle length] && [axDescription length])
> +        return [axTitle stringByAppendingFormat:@", %@", axDescription];
> +    else if ([axTitle length])
> +        return axTitle;
> +    else if ([axDescription length])
> +        return axDescription;

Nit: Might be worth pulling [axTitle length] and [axDescription length] into local variables since they're used multiple times here.

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:687
> +    else if ([self stringValueShouldBeUsedInLabel])
> +        return m_object->stringValue();

Also, is it possible to test all of these code paths (title and description, title only, description only, neither) using a layout test?

If so, the layout test should be changed to test all four scenarios.

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 191046 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191046&action=review
> 
> r=me, but consider expanding the layout test to cover all four scenarios if possible.
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:685
> > +    if ([axTitle length] && [axDescription length])
> > +        return [axTitle stringByAppendingFormat:@", %@", axDescription];
> > +    else if ([axTitle length])
> > +        return axTitle;
> > +    else if ([axDescription length])
> > +        return axDescription;
> 
> Nit: Might be worth pulling [axTitle length] and [axDescription length] into local variables since they're used multiple times here.
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:687
> > +    else if ([self stringValueShouldBeUsedInLabel])
> > +        return m_object->stringValue();
> 
> Also, is it possible to test all of these code paths (title and description, title only, description only, neither) using a layout test?
> 
> If so, the layout test should be changed to test all four scenarios.

Yep, I'll fix up this layout test to test all 4 scenarios.

Thanks!

[chris fleizach]

http://trac.webkit.org/changeset/144766