Bug 111221 - [New Multicolumn] Transformed objects inside fragmented transparent objects don't render
Summary: [New Multicolumn] Transformed objects inside fragmented transparent objects d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 14:28 PST by Dave Hyatt
Modified: 2013-03-01 22:16 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.53 KB, patch)
2013-03-01 17:06 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Tweak some variable names. (17.53 KB, patch)
2013-03-01 17:08 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-03-01 14:28:55 PST 
Transformed objects inside fragmented transparent objects don't render. This is because the clip box we're computing to enclose descendant transformed elements did not account for the fact that they have to be split across columns.
Comment 1 Dave Hyatt 2013-03-01 17:06:21 PST 
Created attachment 191076 [details]
Patch
Comment 2 Dave Hyatt 2013-03-01 17:08:01 PST 
Created attachment 191078 [details]
Tweak some variable names.
Comment 3 WebKit Review Bot 2013-03-01 17:10:19 PST 
Attachment 191078 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/multicol/mixed-opacity-fixed-test-expected.html', u'LayoutTests/fast/multicol/mixed-opacity-fixed-test.html', u'LayoutTests/fast/multicol/mixed-opacity-test-expected.html', u'LayoutTests/fast/multicol/mixed-opacity-test.html', u'LayoutTests/fast/multicol/transform-inside-opacity-expected.html', u'LayoutTests/fast/multicol/transform-inside-opacity.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h']" exit_code: 1
Source/WebCore/rendering/RenderLayer.cpp:1564:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/rendering/RenderLayer.cpp:1570:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/rendering/RenderLayer.cpp:1611:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 3 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2013-03-01 22:16:31 PST 
Fixed in r144529.