RESOLVED FIXED 111212
[V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext() 
https://bugs.webkit.org/show_bug.cgi?id=111212
Summary [V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to...
Kentaro Hara
Reported 2013-03-01 12:47:00 PST
The rename I did in r142424 was wrong. Given that getWorld() returns 0 for the main world, it should be named isolatedWorld(). Similarly, given that getWorldForEnteredContext() returns 0 for the main world, it should be named isolatedWorldForEnteredContext().
Attachments
Patch (10.88 KB, patch)
2013-03-01 12:54 PST, Kentaro Hara 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-03-01 12:54:11 PST
Created attachment 191016 [details] Patch
Adam Barth
Comment 2 2013-03-02 23:11:01 PST
Comment on attachment 191016 [details] Patch ok
WebKit Review Bot
Comment 3 2013-03-02 23:37:32 PST
Comment on attachment 191016 [details] Patch Rejecting attachment 191016 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: WebCore/bindings/v8/V8MutationCallback.cpp -o obj/Source/WebCore/bindings/v8/webcore_remaining.V8MutationCallback.o ../../Source/WebCore/bindings/v8/V8MutationCallback.cpp: In constructor 'WebCore::V8MutationCallback::V8MutationCallback(v8::Handle<v8::Object>, WebCore::ScriptExecutionContext*, v8::Handle<v8::Object>, v8::Isolate*)': ../../Source/WebCore/bindings/v8/V8MutationCallback.cpp:41: error: 'getWorld' is not a member of 'WebCore::DOMWrapperWorld' ninja: build stopped: subcommand failed. Full output: http://webkit-commit-queue.appspot.com/results/16899158
Kentaro Hara
Comment 4 2013-03-03 16:07:50 PST
Committed r144587: <http://trac.webkit.org/changeset/144587>
Note You need to log in before you can comment on or make changes to this bug.