Bug 111200 - Add html-parser-threaded perf test now that the threaded parser is enabled by default
Summary: Add html-parser-threaded perf test now that the threaded parser is enabled by...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 107236
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-03-01 11:12 PST by Eric Seidel (no email)
Modified: 2013-03-05 11:09 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.92 KB, patch)
2013-03-01 11:13 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (6.22 KB, patch)
2013-03-05 01:27 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2013-03-01 11:12:31 PST
Add html-parser-threaded perf test now that the threaded parser is enabled by default
Comment 1 Eric Seidel (no email) 2013-03-01 11:13:56 PST
Created attachment 190996 [details]
Patch
Comment 2 Ryosuke Niwa 2013-03-01 11:20:40 PST
Comment on attachment 190996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190996&action=review

> PerformanceTests/ChangeLog:9
> +

Are values stable? Could you list sample outputs of this test?
Comment 3 Eric Seidel (no email) 2013-03-01 11:44:55 PST
Good question.  The test only seems accurate within .5 sec. :(

I assume I should mark it as skipped for now?

Running 1 tests
Running Parser/html-parser-threaded.html (1 of 1)
RESULT Parser: html-parser-threaded= 6481.615 ms
median= 6462.267 ms, stdev= 492.201657996 ms, min= 5770.78700002 ms, max= 7697.552 ms
RESULT Parser: html-parser-threaded: JSHeap= 3162584.4 bytes
median= 3150244.0 bytes, stdev= 1293464.27469 bytes, min= 1129652.0 bytes, max= 5679636.0 bytes
RESULT Parser: html-parser-threaded: Malloc= 211043848.8 bytes
median= 209918588.0 bytes, stdev= 35644152.6867 bytes, min= 154237584.0 bytes, max= 278692600.0 bytes
Finished: 138.979004 s

Erics-MacBook-Pro [5567:PerformanceTests]% run-perf-tests Parser/html-parser-threaded.html --chromium                                                        [~/Projects/WebKit/PerformanceTests]
    wdiff is not installed; please install from MacPorts or elsewhere

Running 1 tests
Running Parser/html-parser-threaded.html (1 of 1)
RESULT Parser: html-parser-threaded= 6434.6968 ms
median= 6390.426 ms, stdev= 466.679802207 ms, min= 5737.43000001 ms, max= 7561.18000002 ms
RESULT Parser: html-parser-threaded: JSHeap= 3097660.4 bytes
median= 3085456.0 bytes, stdev= 1282908.77539 bytes, min= 1129652.0 bytes, max= 5548680.0 bytes
RESULT Parser: html-parser-threaded: Malloc= 209789260.0 bytes
median= 207639304.0 bytes, stdev= 36461134.7981 bytes, min= 154657400.0 bytes, max= 278346448.0 bytes
Finished: 137.554094 s
Comment 4 Eric Seidel (no email) 2013-03-01 11:46:08 PST
I wonder if something is leaking.  The memory numbers seem rather consistent.
Comment 5 Ryosuke Niwa 2013-03-01 11:48:17 PST
(In reply to comment #4)
> I wonder if something is leaking.  The memory numbers seem rather consistent.

If the memory is leaking, results page should show that. If you click on a row, you should see the tiny graph showing up at the bottom that shows the time series. Make sure to choose "Memory" tab at the left upper corner first.
Comment 6 Eric Seidel (no email) 2013-03-01 11:49:47 PST
(In reply to comment #5)
> (In reply to comment #4)
> > I wonder if something is leaking.  The memory numbers seem rather consistent.
> 
> If the memory is leaking, results page should show that. If you click on a row, you should see the tiny graph showing up at the bottom that shows the time series. Make sure to choose "Memory" tab at the left upper corner first.

The results page hasn't been workign for me.

Uncaught TypeError: Cannot read property 'WebKit' of undefined
Comment 7 Eric Seidel (no email) 2013-03-01 14:39:38 PST
I think this is part of the trouble: bug 107236.
Comment 8 Eric Seidel (no email) 2013-03-05 01:27:45 PST
Created attachment 191433 [details]
Patch
Comment 9 Eric Seidel (no email) 2013-03-05 01:28:19 PST
This adds it back to the skipped list so we can still use it, even though it's off for the bots.
Comment 10 WebKit Review Bot 2013-03-05 11:09:31 PST
Comment on attachment 191433 [details]
Patch

Clearing flags on attachment: 191433

Committed r144785: <http://trac.webkit.org/changeset/144785>
Comment 11 WebKit Review Bot 2013-03-05 11:09:35 PST
All reviewed patches have been landed.  Closing bug.