Bug 111198 – Web Inspector: feature request save/load CPU profile

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector (Deprecated)

[Ilya Tikhonovsky]

EOM

[Ilya Tikhonovsky]

Created attachment 195976 [details]
Patch

[WebKit Review Bot]

Comment on attachment 195976 [details]
Patch

Attachment 195976 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17378173

New failing tests:
inspector/profiler/cpu-profiler-profile-removal.html
inspector/profiler/cpu-profiler-profiling.html

[WebKit Review Bot]

Created attachment 195991 [details]
Archive of layout-test-results from gce-cr-linux-06 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

[Build Bot]

Comment on attachment 195976 [details]
Patch

Attachment 195976 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17377205

New failing tests:
inspector/profiler/cpu-profiler-profile-removal.html
fast/text/emphasis-height-crash.html

[Build Bot]

Created attachment 196017 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Yury Semikhatsky]

Comment on attachment 195976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195976&action=review

Can we test this code?

> Source/WebCore/ChangeLog:10
> +        So I refactored saving mechanic in ProfilesPanel which now doesn't depend on

mechanic -> mechanics

> Source/WebCore/inspector/front-end/CPUProfileView.js:96
> +        this._processProfileData(this.profileHeader._profile);

Can you add a note that this can happen only when the profile is loaded from file?

> Source/WebCore/inspector/front-end/CPUProfileView.js:779
> + * @implements {WebInspector.OutputStreamDelegate}

This is weird, the same class is stream and delegate?

> Source/WebCore/inspector/front-end/CPUProfileView.js:816
> +    onError: function(reader, event) { },

Can we print something to the console?

> Source/WebCore/inspector/front-end/CPUProfileView.js:826
> +    close: function() { },

{} on separate lines

> Source/WebCore/inspector/front-end/CPUProfileView.js:870
> +                // Profiling was tentatively terminated with the "Clear all profiles." button.

tentatively ?

[Ilya Tikhonovsky]

Created attachment 196316 [details]
Patch

[Ilya Tikhonovsky]

not landed