WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111195
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
https://bugs.webkit.org/show_bug.cgi?id=111195
Summary
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuf...
Aaron Colwell
Reported
2013-03-01 10:58:04 PST
I accidentally added a boolean return value to SourceBufferPrivate::abort() and WebSourceBuffer::abort() that is not used anywhere. This should be removed.
Attachments
Patch
(5.46 KB, patch)
2013-03-01 11:03 PST
,
Aaron Colwell
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aaron Colwell
Comment 1
2013-03-01 11:03:13 PST
Created
attachment 190992
[details]
Patch
WebKit Review Bot
Comment 2
2013-03-01 11:06:14 PST
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
Adam Barth
Comment 3
2013-03-02 23:13:46 PST
Comment on
attachment 190992
[details]
Patch ok
WebKit Review Bot
Comment 4
2013-03-03 00:29:56 PST
Comment on
attachment 190992
[details]
Patch Rejecting
attachment 190992
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190992, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output:
http://webkit-commit-queue.appspot.com/results/16898247
WebKit Review Bot
Comment 5
2013-03-04 09:26:43 PST
Comment on
attachment 190992
[details]
Patch Clearing flags on attachment: 190992 Committed
r144638
: <
http://trac.webkit.org/changeset/144638
>
WebKit Review Bot
Comment 6
2013-03-04 09:26:47 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug