Bug 111191 – Web Inspector: add Ace editor experiment

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Lushnikov]

Add ace editor experiment.

[Andrey Lushnikov]

Created attachment 190981 [details]
Patch

[Andrey Lushnikov]

Created attachment 190982 [details]
Patch

[Pavel Feldman]

Comment on attachment 190982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190982&action=review

Could you share the stats on how much bigger the front-end footprint will be? In absolute numbers as well as percentage. Raw, minified and zipped (chromium resources are zipped).

> Source/WebCore/inspector/front-end/AceTextEditor.js:48
> +    this.element.style.height = "100%";

Please use CSS for styling.

> Source/WebCore/inspector/front-end/AceTextEditor.js:84
> +            case "text/html": this._aceEditor.getSession().setMode("ace/mode/html"); break;

Do not indent case from switch.

[Andrey Lushnikov]

Created attachment 190985 [details]
Patch

[Andrey Lushnikov]

Some stats on Ace disk usage:
1. Raw folder size of Ace files in this patch is 664Kb
2. If I were to put minified version of ace files, it would be 376Kb

I estimated gzip size of devtools_resources.pak file. 
Without this patch: 824Kb
With this patch: 956Kb
So it brings in 132Kb of overhead.

[Andrey Lushnikov]

Created attachment 191174 [details]
Patch

[Pavel Feldman]

Comment on attachment 191174 [details]
Patch

Please make sure you include original BSD LICENSE file.

[Andrey Lushnikov]

Created attachment 191176 [details]
Patch

[WebKit Review Bot]

Comment on attachment 191176 [details]
Patch

Clearing flags on attachment: 191176

Committed r144615: <http://trac.webkit.org/changeset/144615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Fabian Jakobs]

Hi, I'm the author of ace and very excited to see it landing in Chrome. I have noticed a few glitches with this patch:

- the breakpoint context menu does not work
- I don't get syntax highlighting for css files

If you prefer I can create separate issues for this.

[Andrey Lushnikov]

Hi Fabian,

First of all, thank you for your great project!

We are aware of the bugs you've mentioned. We've added Ace editor as an experiment and it's not fully embedded into the devtools (that's the reason for the glitches you've mentioned). There's no decision yet if we would invest efforts in its adoption and use it as our primary code editor.