Bug 111186 - [CSS Exclusions] Incorrect margin corner radii formula
Summary: [CSS Exclusions] Incorrect margin corner radii formula
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 110499
  Show dependency tree / graph
 
Reported: 2013-03-01 08:44 PST by Hans Muller
Modified: 2013-03-29 13:32 PDT (History)
4 users (show)

See Also:

Attachments
Test case. (6.86 KB, text/html)
2013-03-28 12:46 PDT, Hans Muller 		no flags Details
Screenshot of the failing test case. (65.66 KB, image/png)
2013-03-28 12:47 PDT, Hans Muller 		no flags Details
Patch (12.02 KB, patch)
2013-03-29 11:53 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-03-01 08:44:43 PST 
Jim Graham pointed out that the current formula for margin corner radii was incorrect in my blog (http://hansmuller-webkit.blogspot.com/2013/02/padding-rounded-rectangle.html).  It's also currently wrong in FloatRoundedRect::marginBounds():

    float boundsRadiusX = std::max(rx(), margin);
    float boundsRadiusY = std::max(ry(), margin);

Should be:

    float boundsRadiusX = rx() + margin;
    float boundsRadiusY = ry() + margin;

I've corrected the blog :-).
Comment 1 Hans Muller 2013-03-28 12:46:11 PDT 
Created attachment 195621 [details]
Test case.
Comment 2 Hans Muller 2013-03-28 12:47:07 PDT 
Created attachment 195623 [details]
Screenshot of the failing test case.
Comment 3 Hans Muller 2013-03-29 11:53:29 PDT 
Created attachment 195772 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-29 13:32:34 PDT 
Comment on attachment 195772 [details]
Patch

Clearing flags on attachment: 195772

Committed r147249: <http://trac.webkit.org/changeset/147249>
Comment 5 WebKit Review Bot 2013-03-29 13:32:37 PDT 
All reviewed patches have been landed.  Closing bug.