RESOLVED FIXED 111184
Web Inspector: add runtime flag to determine if inspector's source files were flattened. 
https://bugs.webkit.org/show_bug.cgi?id=111184
Summary Web Inspector: add runtime flag to determine if inspector's source files were...
Andrey Lushnikov
Reported 2013-03-01 08:40:00 PST
We want inspector to operate successfully in three different modes: 1. debug_devtools = 0 2. debug_devtools = 1 3. serving front-end from its source directory In the first two modes, inspector is deployed by the means of build system, which moves js and css files from nested directories into root. In the third mode, inspector's files are hierarchical. This makes it hard for inspector to load its resources dynamically. If there were a runtime flag, inspector would be able to determine a way to load its resources dynamically.
Attachments
Patch (7.28 KB, patch)
2013-03-01 08:48 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (7.98 KB, patch)
2013-03-01 09:22 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (8.00 KB, patch)
2013-03-01 10:30 PST, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-03-01 08:48:32 PST
Created attachment 190973 [details] Patch
Andrey Lushnikov
Comment 2 2013-03-01 09:22:00 PST
Created attachment 190977 [details] Patch
Pavel Feldman
Comment 3 2013-03-01 10:05:31 PST
Comment on attachment 190977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190977&action=review One small issue and it is good to go. > Source/WebKit/chromium/scripts/generate_devtools_html.py:59 > + devtools_file.write(generate_include_tag("buildSystemOnly.js")) This should be the first include to be written.
Pavel Feldman
Comment 4 2013-03-01 10:07:03 PST
Comment on attachment 190977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190977&action=review > Source/WebCore/inspector/front-end/View.js:302 > + if (window.flattenImports) You break compilation here too, no? Need to add it into externs.
Andrey Lushnikov
Comment 5 2013-03-01 10:30:51 PST
Created attachment 190984 [details] Patch
WebKit Review Bot
Comment 6 2013-03-04 00:39:42 PST
Comment on attachment 190984 [details] Patch Clearing flags on attachment: 190984 Committed r144605: <http://trac.webkit.org/changeset/144605>
WebKit Review Bot
Comment 7 2013-03-04 00:39:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.