Changing "#define YYDEBUG 0: in Source/WebCore/css/CSSGrammar.y.includes to 1 causes compilation error.
Created attachment 190960 [details] Patch
Comment on attachment 190960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190960&action=review > Source/WebCore/ChangeLog:3 > + Fixed. This is unnecessary. > Source/WebCore/ChangeLog:5 > + CSS debugging code is broken This is too vague. > Source/WebCore/ChangeLog:16 > + * css/CSSGrammar.y.includes: > + * css/CSSParser.cpp: > + (WebCore::CSSParser::rewriteSpecifiers): > + * css/CSSParser.h: > + (WebCore): These are here so you can provide a description of what changes you made, and why. > Source/WebCore/css/CSSParser.cpp:11964 > +String yylvalToString(int yytype, const void* yylvalWithoutType) Why is this implemented unconditionally when it's only ever used when YYDEBUG is > 0? > Source/WebCore/css/CSSParser.h:713 > + Why is this defined unconditionally when it's only ever used when YYDEBUG is > 0?
Created attachment 193992 [details] Patch
Comment on attachment 190960 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190960&action=review I moved this code to CSSGrammar.y.in. I hope it make it easier to understand. >> Source/WebCore/css/CSSParser.cpp:11964 >> +String yylvalToString(int yytype, const void* yylvalWithoutType) > > Why is this implemented unconditionally when it's only ever used when YYDEBUG is > 0? Because YYDEBUG from CSSGrammar.y.include if completely different from one defined in CSSParser.cpp. Is inaccessible here. I prefer to use only one from CSSGrammar.y.include in order to have more precise contron on what stylesheet to debug.
Comment on attachment 193992 [details] Patch Clearing flags on attachment: 193992 Committed r146451: <http://trac.webkit.org/changeset/146451>
All reviewed patches have been landed. Closing bug.