Bug 111165 - Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
Summary: Web Inspector: Introduce opaque SecurityOrigin string identifiers in the fron...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks: 110960
  Show dependency tree / graph
 
Reported: 2013-03-01 04:48 PST by Alexander Pavlov (apavlov)
Modified: 2013-03-03 23:45 PST (History)
8 users (show)

See Also:

Attachments
Patch (52.62 KB, patch)
2013-03-01 07:07 PST, Alexander Pavlov (apavlov) 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2013-03-01 04:48:39 PST 
This task has been split out of bug 110960.

Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2013-03-01 07:07:53 PST 
Created attachment 190963 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-01 07:30:29 PST 
Comment on attachment 190963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190963&action=review

> Source/WebCore/inspector/front-end/ExtensionServer.js:800
> +            var originObject = new WebInspector.SecurityOrigin(securityOrigin, securityOrigin);

Let's revert this change.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:771
> +    equal: function(other)

equals

> Source/WebCore/inspector/front-end/RuntimeModel.js:77
> +     * @param {WebInspector.SecurityOrigin} securityOrigin

RuntimeModel.js changes should be reverted.
Comment 3 Alexander Pavlov (apavlov) 2013-03-01 07:39:12 PST 
Committed r144455: <http://trac.webkit.org/changeset/144455>
Comment 4 Andrey Kosyakov 2013-03-01 08:43:03 PST 
Comment on attachment 190963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190963&action=review

> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:34
> + * @param {WebInspector.SecurityOrigin} extensionOrigin

This got landed. Please revert.
Comment 5 Alexander Pavlov (apavlov) 2013-03-03 23:30:57 PST 
Reverted r144455 for reason:

A simpler solution to the SecurityOrigin -> localStorage lookup exists

Committed r144600: <http://trac.webkit.org/changeset/144600>
Comment 6 Alexander Pavlov (apavlov) 2013-03-03 23:45:43 PST 
Closing, since bug 110960 is WONTFIX.