WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
111165
Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
https://bugs.webkit.org/show_bug.cgi?id=111165
Summary
Web Inspector: Introduce opaque SecurityOrigin string identifiers in the fron...
Alexander Pavlov (apavlov)
Reported
2013-03-01 04:48:39 PST
This task has been split out of
bug 110960
. Patch to follow.
Attachments
Patch
(52.62 KB, patch)
2013-03-01 07:07 PST
,
Alexander Pavlov (apavlov)
vsevik
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1
2013-03-01 07:07:53 PST
Created
attachment 190963
[details]
Patch
Vsevolod Vlasov
Comment 2
2013-03-01 07:30:29 PST
Comment on
attachment 190963
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=190963&action=review
> Source/WebCore/inspector/front-end/ExtensionServer.js:800 > + var originObject = new WebInspector.SecurityOrigin(securityOrigin, securityOrigin);
Let's revert this change.
> Source/WebCore/inspector/front-end/ResourceTreeModel.js:771 > + equal: function(other)
equals
> Source/WebCore/inspector/front-end/RuntimeModel.js:77 > + * @param {WebInspector.SecurityOrigin} securityOrigin
RuntimeModel.js changes should be reverted.
Alexander Pavlov (apavlov)
Comment 3
2013-03-01 07:39:12 PST
Committed
r144455
: <
http://trac.webkit.org/changeset/144455
>
Andrey Kosyakov
Comment 4
2013-03-01 08:43:03 PST
Comment on
attachment 190963
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=190963&action=review
> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:34 > + * @param {WebInspector.SecurityOrigin} extensionOrigin
This got landed. Please revert.
Alexander Pavlov (apavlov)
Comment 5
2013-03-03 23:30:57 PST
Reverted
r144455
for reason: A simpler solution to the SecurityOrigin -> localStorage lookup exists Committed
r144600
: <
http://trac.webkit.org/changeset/144600
>
Alexander Pavlov (apavlov)
Comment 6
2013-03-03 23:45:43 PST
Closing, since
bug 110960
is WONTFIX.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug