Bug 111160 - [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
Summary: [GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-03-01 04:09 PST by Carlos Garcia Campos
Modified: 2013-03-08 02:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2013-03-01 04:11 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-03-01 04:09:25 PST 
leakRef() is used for the returned PassRefPtr without taking the ownership of the leaked ref.
Comment 1 Carlos Garcia Campos 2013-03-01 04:11:50 PST 
Created attachment 190931 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-03-01 04:12:13 PST 
Adding WebKit2 owners to CC.
Comment 3 WebKit Review Bot 2013-03-01 04:20:13 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Martin Robinson 2013-03-01 10:09:28 PST 
Comment on attachment 190931 [details]
Patch

Yikes. Looks good to me.
Comment 5 Benjamin Poulain 2013-03-08 02:21:35 PST 
Comment on attachment 190931 [details]
Patch

Ouch :)

Funny leakRef() was even used in this context.
Comment 6 Carlos Garcia Campos 2013-03-08 02:25:41 PST 
(In reply to comment #5)
> (From update of attachment 190931 [details])
> Ouch :)
> 
> Funny leakRef() was even used in this context.

Yeah, an unfortunate copy paste from another place where it made sense. Thanks for the review!
Comment 7 WebKit Review Bot 2013-03-08 02:42:20 PST 
Comment on attachment 190931 [details]
Patch

Clearing flags on attachment: 190931

Committed r145202: <http://trac.webkit.org/changeset/145202>
Comment 8 WebKit Review Bot 2013-03-08 02:42:24 PST 
All reviewed patches have been landed.  Closing bug.