Bug 111142 - Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
Summary: Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency treegraph
 
Reported: 2013-02-28 22:18 PST by Ryosuke Niwa
Modified: 2013-02-28 22:36 PST (History)
4 users (show)

See Also:


Attachments
Cleanup (5.73 KB, patch)
2013-02-28 22:22 PST, Ryosuke Niwa
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-02-28 22:18:45 PST
Another refactoring.  _run_single_test and _run_tests_set should be a single method.
Comment 1 Ryosuke Niwa 2013-02-28 22:22:04 PST
Created attachment 190885 [details]
Cleanup
Comment 2 Adam Barth 2013-02-28 22:32:03 PST
Comment on attachment 190885 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371
> +                _log.error('FAILED')

I guess we don't say which test failed.
Comment 3 Ryosuke Niwa 2013-02-28 22:35:39 PST
Comment on attachment 190885 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=190885&action=review

>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:371
>> +                _log.error('FAILED')
> 
> I guess we don't say which test failed.

Ordinarily, we see the test name right above it:

Running DOM/CreateNodes.html (32 of 113)
error: DOM/CreateNodes.html
Received an invalid message "WebPageProxy.DidFailProvisionalLoadForFrame" from the web process.
FAILED
Finished: 18.626504 s
Comment 4 Ryosuke Niwa 2013-02-28 22:36:16 PST
Committed r144421: <http://trac.webkit.org/changeset/144421>