Bug 111139 - [WK2] Create a port independent test view for Coordinated Graphics
Summary: [WK2] Create a port independent test view for Coordinated Graphics
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luiz Agostini
URL:
Keywords:
Depends on: 110323
Blocks: 111140
  Show dependency treegraph
 
Reported: 2013-02-28 21:59 PST by Luiz Agostini
Modified: 2013-07-17 19:15 PDT (History)
12 users (show)

See Also:


Attachments
patch (15.03 KB, patch)
2013-03-01 01:51 PST, Luiz Agostini
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch (16.26 KB, patch)
2013-03-06 04:21 PST, Luiz Agostini
noam: review-
eflews.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2013-02-28 21:59:06 PST
It would be nice to have a very simple Coordinated Graphics view that is independent from Qt or Efl.
That view would be used on port independent API tests for Coordinated Graphics.
Comment 1 Luiz Agostini 2013-03-01 01:51:42 PST
Created attachment 190910 [details]
patch
Comment 2 Luiz Agostini 2013-03-01 01:57:02 PST
the patch is not expected to build without bug #110323.
Comment 3 EFL EWS Bot 2013-03-01 01:58:02 PST
Comment on attachment 190910 [details]
patch

Attachment 190910 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16795388
Comment 4 Luiz Agostini 2013-03-06 04:21:04 PST
Created attachment 191714 [details]
patch
Comment 5 Kenneth Rohde Christiansen 2013-03-06 04:29:48 PST
Comment on attachment 191714 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47
> +class CoordinatedPageClient : public WebKit::PageClient {

I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:60
> +    virtual void didReceiveMessageFromNavigatorQtObject(const String&) { notImplemented(); }

doesnt look so port independent.
Comment 6 Luiz Agostini 2013-03-06 10:59:27 PST
(In reply to comment #5)
> (From update of attachment 191714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191714&action=review
> 
> > Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedView.cpp:47
> > +class CoordinatedPageClient : public WebKit::PageClient {
> 
> I dont see how this will work together with the EFL WKView. Can't you not just test it using EFL for now and we turn our WKView cross platform later

It would be just a simple view for tests. Just want to be less intrusive. For example, having this view, WKView does not need to expose its WKCoordinatedScene for us to be able to test.
Comment 7 EFL EWS Bot 2013-04-23 17:44:37 PDT
Comment on attachment 191714 [details]
patch

Attachment 191714 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/183121
Comment 8 Noam Rosenthal 2013-07-17 19:15:55 PDT
Comment on attachment 191714 [details]
patch

Doesn't seem relevant anymore :)