Bug 111132 – [WK2] Make in-memory blobs work in NetworkProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Alexey Proskuryakov]

This patch makes blobs work, except it doesn't track sandbox extensions for files.

[Alexey Proskuryakov]

Created attachment 190859 [details]
proposed patch

[WebKit Review Bot]

Attachment 190859 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.h', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h']" exit_code: 1
Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp:126:  Extra space before ) in for  [whitespace/parens] [5]
Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:254:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16672802

[EFL EWS Bot]

Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16783431

[Adam Barth]

Comment on attachment 190859 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190859&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.h:53
> +    virtual WebCore::BlobRegistry* createBlobRegistry() OVERRIDE;

Not PassOwnPtr?

[Build Bot]

Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16753242

[Alexey Proskuryakov]

> Not PassOwnPtr?

PassOwnPtr cannot be used with BlobRegistry, because its destructor is protected.

One way or another, we never delete these.

[Build Bot]

Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16785114

[Alexey Proskuryakov]

Created attachment 190989 [details]
with some build fixing

Unsure what went wrong with Mac builds, trying again. This should fix Qt and EFL though.

[Alexey Proskuryakov]

Created attachment 190990 [details]
fix style too

[Build Bot]

Comment on attachment 190990 [details]
fix style too

Attachment 190990 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16675348

[Alexey Proskuryakov]

Created attachment 191001 [details]
with more build fix

The new Mac build failure made sense.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/144499>.