Bug 111132 - [WK2] Make in-memory blobs work in NetworkProcess
Summary: [WK2] Make in-memory blobs work in NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 17:37 PST by Alexey Proskuryakov
Modified: 2013-03-01 14:03 PST (History)
7 users (show)

See Also:


Attachments
proposed patch (40.65 KB, patch)
2013-02-28 17:53 PST, Alexey Proskuryakov
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
with some build fixing (44.85 KB, patch)
2013-03-01 10:59 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
fix style too (44.84 KB, patch)
2013-03-01 11:02 PST, Alexey Proskuryakov
buildbot: commit-queue-
Details | Formatted Diff | Diff
with more build fix (44.81 KB, patch)
2013-03-01 11:55 PST, Alexey Proskuryakov
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-02-28 17:37:31 PST
This patch makes blobs work, except it doesn't track sandbox extensions for files.
Comment 1 Alexey Proskuryakov 2013-02-28 17:53:13 PST
Created attachment 190859 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-02-28 17:57:13 PST
Attachment 190859 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.h', u'Source/WebKit2/NetworkProcess/NetworkConnectionToWebProcess.messages.in', u'Source/WebKit2/NetworkProcess/NetworkProcess.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.cpp', u'Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.h', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp', u'Source/WebKit2/Shared/FileAPI/BlobRegistrationData.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp', u'Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h']" exit_code: 1
Source/WebKit2/WebProcess/FileAPI/BlobRegistryProxy.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp:126:  Extra space before ) in for  [whitespace/parens] [5]
Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:254:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 3 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-02-28 18:01:27 PST
Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16672802
Comment 4 EFL EWS Bot 2013-02-28 18:03:01 PST
Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16783431
Comment 5 Adam Barth 2013-02-28 18:12:31 PST
Comment on attachment 190859 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190859&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessPlatformStrategies.h:53
> +    virtual WebCore::BlobRegistry* createBlobRegistry() OVERRIDE;

Not PassOwnPtr?
Comment 6 Build Bot 2013-02-28 18:33:11 PST
Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16753242
Comment 7 Alexey Proskuryakov 2013-02-28 18:38:52 PST
> Not PassOwnPtr?

PassOwnPtr cannot be used with BlobRegistry, because its destructor is protected.

One way or another, we never delete these.
Comment 8 Build Bot 2013-02-28 19:02:43 PST
Comment on attachment 190859 [details]
proposed patch

Attachment 190859 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16785114
Comment 9 Alexey Proskuryakov 2013-03-01 10:59:21 PST
Created attachment 190989 [details]
with some build fixing

Unsure what went wrong with Mac builds, trying again. This should fix Qt and EFL though.
Comment 10 Alexey Proskuryakov 2013-03-01 11:02:08 PST
Created attachment 190990 [details]
fix style too
Comment 11 Build Bot 2013-03-01 11:35:45 PST
Comment on attachment 190990 [details]
fix style too

Attachment 190990 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16675348
Comment 12 Alexey Proskuryakov 2013-03-01 11:55:39 PST
Created attachment 191001 [details]
with more build fix

The new Mac build failure made sense.
Comment 13 Alexey Proskuryakov 2013-03-01 14:03:03 PST
Committed <http://trac.webkit.org/changeset/144499>.