Bug 111110 - [New Multicolumn] Change flow thread containment to be a state
Summary: [New Multicolumn] Change flow thread containment to be a state
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2013-02-28 13:56 PST by Dave Hyatt
Modified: 2013-03-01 09:00 PST (History)
5 users (show)

See Also:

Patch (11.90 KB, patch)
2013-02-28 15:04 PST, Dave Hyatt
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-02-28 13:56:35 PST
Instead of a single boolean for inside a flow thread or not, I'm changing it to be a state so that we can know if we're inside an in-flow or out-of-flow flow thread. This is important for distinguishing between the two, since in the in-flow case content can escape, so we're going to have to clear the bit and do some more work to keep it up-to-date.
Comment 1 Dave Hyatt 2013-02-28 15:04:40 PST
Created attachment 190817 [details]
Comment 2 Andreas Kling 2013-03-01 08:26:18 PST
Comment on attachment 190817 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=190817&action=review


> Source/WebCore/rendering/RenderObject.h:1129
> +        unsigned m_flowThreadState : 2; // FlowThreadState

There's a comment above about the number of remaining bits that should be updated.
Comment 3 Dave Hyatt 2013-03-01 09:00:41 PST
Landed in r144461.