Bug 111106 - CodeBlock::valueProfile() has a bogus assertion
Summary: CodeBlock::valueProfile() has a bogus assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-28 13:25 PST by Filip Pizlo
Modified: 2013-02-28 13:33 PST (History)
7 users (show)

See Also:

Attachments
the patch (2.87 KB, patch)
2013-02-28 13:29 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-02-28 13:25:00 PST 
<rdar://problem/13131427>
Comment 1 Filip Pizlo 2013-02-28 13:29:08 PST 
Created attachment 190797 [details]
the patch
Comment 2 Filip Pizlo 2013-02-28 13:30:01 PST 
Comment on attachment 190797 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190797&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        This was just a bad assertion: m_bytecodeOffset means that the value profile is constructed but not initialized.

should say:

This was just a bad assertion: m_bytecodeOffset == -1 means that the value profile is constructed but not initialized.
Comment 3 Mark Hahnenberg 2013-02-28 13:30:46 PST 
Comment on attachment 190797 [details]
the patch

r=me
Comment 4 Filip Pizlo 2013-02-28 13:33:21 PST 
Landed in http://trac.webkit.org/changeset/144356