Bug 111101 – [chromium] remove deprecated hyphenation methods from Platform

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] remove deprecated hyphenation methods from Platform

Created attachment 190783 [details]
Patch

I'll first need to roll the chromium-deps before this passes EWS, but the patch is simple enough anyway

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 190783 [details]
Patch

Attachment 190783 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16687501

[WebKit Review Bot]

Comment on attachment 190783 [details]
Patch

Attachment 190783 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16819402

[Peter Beverloo (cr-android ews)]

Comment on attachment 190783 [details]
Patch

Attachment 190783 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16789362

[WebKit Review Bot]

Comment on attachment 190783 [details]
Patch

Rejecting attachment 190783 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
eclaration of 'struct WebKit::WebHyphenator'
../../Source/WebCore/platform/text/chromium/Hyphenation.cpp: In function 'size_t WebCore::lastHyphenLocation(const UChar*, size_t, size_t, const WTF::AtomicString&)':
../../Source/WebCore/platform/text/chromium/Hyphenation.cpp:40: error: invalid use of incomplete type 'struct WebKit::WebHyphenator'
../../Source/Platform/chromium/public/Platform.h:62: error: forward declaration of 'struct WebKit::WebHyphenator'
ninja: build stopped: subcommand failed.

Full output: http://webkit-commit-queue.appspot.com/results/16930002

Created attachment 191246 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 191246 [details]
Patch for landing

Rejecting attachment 191246 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191246, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13779 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
54>At revision 13779.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/16919028

[Adam Barth]

Comment on attachment 191246 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=191246&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

The OOPS here is preventing this patch from landing

Oops

Created attachment 191280 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 191280 [details]
Patch for landing

Clearing flags on attachment: 191280

Committed r144660: <http://trac.webkit.org/changeset/144660>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.