WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111099
XSSAuditor should use threadSafeMatch when relevant.
https://bugs.webkit.org/show_bug.cgi?id=111099
Summary
XSSAuditor should use threadSafeMatch when relevant.
Mike West
Reported
2013-02-28 12:12:17 PST
In XSSAuditor::hasName, there's a use of equalIgnoringNullity that can be trivially replaced with threadSafeMatch. That seems like a good thing to do. We're also using equalIgnoringNullity in XSSAuditor::findAttributeWithName, but that usage seems safe, since we're creating a new string to do the comparison against.
Attachments
Patch
(1.98 KB, patch)
2013-02-28 12:19 PST
,
Mike West
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mike West
Comment 1
2013-02-28 12:19:08 PST
Created
attachment 190779
[details]
Patch
WebKit Review Bot
Comment 2
2013-03-01 00:49:18 PST
Comment on
attachment 190779
[details]
Patch Clearing flags on attachment: 190779 Committed
r144425
: <
http://trac.webkit.org/changeset/144425
>
WebKit Review Bot
Comment 3
2013-03-01 00:49:21 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug