WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
111090
[texmap] Remove redundant defines on TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=111090
Summary
[texmap] Remove redundant defines on TextureMapperGL
Bruno Abinader (history only)
Reported
2013-02-28 10:32:28 PST
Used inside TextureMapperGL::updateContentsNoSwizzle(), the driverSupportsSubImage() function already uses OpenGL ES defines to return correct support, thus no need for additional defines.
Attachments
Patch
(2.81 KB, patch)
2013-02-28 10:33 PST
,
Bruno Abinader (history only)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1
2013-02-28 10:33:57 PST
Created
attachment 190753
[details]
Patch Proposed patch
Antonio Gomes
Comment 2
2013-02-28 10:58:42 PST
Comment on
attachment 190753
[details]
Patch Igor?
Igor Trindade Oliveira
Comment 3
2013-02-28 12:39:50 PST
cq'ed
WebKit Review Bot
Comment 4
2013-02-28 13:11:07 PST
Comment on
attachment 190753
[details]
Patch Rejecting
attachment 190753
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190753, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output:
http://webkit-commit-queue.appspot.com/results/16666457
Bruno Abinader (history only)
Comment 5
2013-02-28 13:17:07 PST
Comment on
attachment 190753
[details]
Patch Commit-queue seems sick, trying again...
WebKit Review Bot
Comment 6
2013-02-28 13:39:42 PST
Comment on
attachment 190753
[details]
Patch Clearing flags on attachment: 190753 Committed
r144359
: <
http://trac.webkit.org/changeset/144359
>
WebKit Review Bot
Comment 7
2013-02-28 13:39:45 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug