Bug 111089 – Remove the quirk margin bits from RenderObject and put them back in RenderBlock

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

I need to free up some bits in RenderObject, and these bits really only applied to RenderBlocks, so I'm moving them back down.

[Dave Hyatt]

Created attachment 190752 [details]
Patch

[WebKit Review Bot]

Attachment 190752 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:2349:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/rendering/RenderBlock.cpp:7654:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7655:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7671:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7672:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 190752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190752&action=review

> Source/WebCore/rendering/RenderBlock.h:152
> +    bool childHasMarginBeforeQuirk(const RenderBox* child) const;
> +    bool childHasMarginAfterQuirk(const RenderBox* child) const;

Probably don’t need the name “child” here.

[Eric Seidel (no email)]

Comment on attachment 190752 [details]
Patch

LGTM.

[Dave Hyatt]

Landed in r144344.

[WebKit Review Bot]

Re-opened since this is blocked by bug 111105

[Ahmad Saleem]

This landed but didn't rolled out but fixed in this:

https://trac.webkit.org/changeset/144364/webkit

Marking this as "RESOLVED FIXED". Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/100169946>