Bug 111089 - Remove the quirk margin bits from RenderObject and put them back in RenderBlock
Summary: Remove the quirk margin bits from RenderObject and put them back in RenderBlock
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on: 111105
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-28 10:31 PST by Dave Hyatt
Modified: 2013-02-28 13:15 PST (History)
4 users (show)

See Also:


Attachments
Patch (18.19 KB, patch)
2013-02-28 10:33 PST, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2013-02-28 10:31:17 PST
I need to free up some bits in RenderObject, and these bits really only applied to RenderBlocks, so I'm moving them back down.
Comment 1 Dave Hyatt 2013-02-28 10:33:26 PST
Created attachment 190752 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-28 10:34:40 PST
Attachment 190752 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/style/RenderStyle.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:2349:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/rendering/RenderBlock.cpp:7654:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7655:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7671:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:7672:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2013-02-28 10:36:39 PST
Comment on attachment 190752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190752&action=review

> Source/WebCore/rendering/RenderBlock.h:152
> +    bool childHasMarginBeforeQuirk(const RenderBox* child) const;
> +    bool childHasMarginAfterQuirk(const RenderBox* child) const;

Probably don’t need the name “child” here.
Comment 4 Eric Seidel (no email) 2013-02-28 10:37:34 PST
Comment on attachment 190752 [details]
Patch

LGTM.
Comment 5 Dave Hyatt 2013-02-28 12:01:22 PST
Landed in r144344.
Comment 6 WebKit Review Bot 2013-02-28 13:15:44 PST
Re-opened since this is blocked by bug 111105