Bug 111064 - Web Inspector: fix code-mirror experiment to work in debug mode
Summary: Web Inspector: fix code-mirror experiment to work in debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Lushnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 03:23 PST by Andrey Lushnikov
Modified: 2013-03-01 01:39 PST (History)
9 users (show)

See Also:

Attachments
Patch (10.59 KB, patch)
2013-02-28 03:34 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Patch (1.86 KB, patch)
2013-03-01 01:00 PST, Andrey Lushnikov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Lushnikov 2013-02-28 03:23:50 PST 
fix code-mirror experiment to work with "debug_devtools" flag been set to 1
Comment 1 Andrey Lushnikov 2013-02-28 03:34:49 PST 
Created attachment 190693 [details]
Patch
Comment 2 Pavel Feldman 2013-02-28 03:38:15 PST 
Comment on attachment 190693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190693&action=review

> Source/WebCore/WebCore.gypi:5208
> +            'inspector/front-end/CodeMirrorTextEditor.js',

How come it is in two places at a time?

> Source/WebCore/WebCore.gypi:5466
> +        'webinspector_codemirror_inline_files': [

We had no notion of inline files, just modules. Why making things complex?

> Source/WebCore/WebCore.gypi:5478
> +        'webinspector_debug_standalone_files': [

This hurts modularity - this is about cm, not standalone?

> Source/WebKit/chromium/WebKit.gyp:856
> +                                ['include', '/cm/'],

I think we should either split all modules by folders or not do it at all.
Comment 3 Andrey Lushnikov 2013-03-01 01:00:47 PST 
Created attachment 190904 [details]
Patch
Comment 4 WebKit Review Bot 2013-03-01 01:39:44 PST 
Comment on attachment 190904 [details]
Patch

Clearing flags on attachment: 190904

Committed r144428: <http://trac.webkit.org/changeset/144428>
Comment 5 WebKit Review Bot 2013-03-01 01:39:48 PST 
All reviewed patches have been landed.  Closing bug.