Bug 111049 - Cleanup: XSSAuditor form[action] tests should be manually executable.
Summary: Cleanup: XSSAuditor form[action] tests should be manually executable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P5 Trivial
Assignee: Mike West
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 01:00 PST by Mike West
Modified: 2013-02-28 02:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2013-02-28 01:03 PST, Mike West 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike West 2013-02-28 01:00:43 PST 
XSSAuditor form[action] tests should be manually executable.
Comment 1 Mike West 2013-02-28 01:03:36 PST 
Created attachment 190674 [details]
Patch
Comment 2 Mike West 2013-02-28 01:06:14 PST 
Following up on dbates' recommendation in https://bugs.webkit.org/show_bug.cgi?id=110975, I'm splitting out this drive-by nit into a separate patch. In the future, migrating these tests to 'js-test-pre.js' seems like a good thing to do, but for the moment, simply ensuring that they work correctly when run manually is worthwhile (and trivial).
Comment 3 Daniel Bates 2013-02-28 01:32:02 PST 
Comment on attachment 190674 [details]
Patch

Thank you Mike for splitting this off into a separate patch.
Comment 4 Mike West 2013-02-28 01:34:22 PST 
(In reply to comment #3)
> (From update of attachment 190674 [details])
> Thank you Mike for splitting this off into a separate patch.

Tiny patches are cheap. :)

Thanks for taking a look!
Comment 5 WebKit Review Bot 2013-02-28 02:09:23 PST 
Comment on attachment 190674 [details]
Patch

Clearing flags on attachment: 190674

Committed r144282: <http://trac.webkit.org/changeset/144282>
Comment 6 WebKit Review Bot 2013-02-28 02:09:26 PST 
All reviewed patches have been landed.  Closing bug.