RESOLVED FIXED 111030
Merge more methods on PerfTest 
https://bugs.webkit.org/show_bug.cgi?id=111030
Summary Merge more methods on PerfTest
Ryosuke Niwa
Reported 2013-02-27 19:08:07 PST
PerfTest has way too many miscellaneous methods. Merge them as much as we can to make the class more coherent and comprehensible.
Attachments
Cleanup (9.53 KB, patch)
2013-02-27 19:13 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-02-27 19:13:43 PST
Created attachment 190635 [details] Cleanup
WebKit Review Bot
Comment 2 2013-02-27 20:33:31 PST
Attachment 190635 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/performance_tests/perftest.py', u'Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py']" exit_code: 1 Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:166: [TestPerfTest.test_parse_output_with_failing_line] Instance of 'TestPerfTest' has no 'assertIsNone' member [pylint/E1101] [5] Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:201: [TestPerfTest.test_ignored_stderr_lines] Instance of 'TestPerfTest' has no 'assertEqual' member [pylint/E1101] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Pranke
Comment 3 2013-02-28 12:53:27 PST
Comment on attachment 190635 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190635&action=review >> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:166 >> + self.assertIsNone(test._run_with_driver(None, None)) > > [TestPerfTest.test_parse_output_with_failing_line] Instance of 'TestPerfTest' has no 'assertIsNone' member [pylint/E1101] [5] I think this are false positives having to do with our unittest2 shenanigans. Mind filing a bug for that?
Ryosuke Niwa
Comment 4 2013-02-28 13:45:05 PST
Comment on attachment 190635 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=190635&action=review >>> Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py:166 >>> + self.assertIsNone(test._run_with_driver(None, None)) >> >> [TestPerfTest.test_parse_output_with_failing_line] Instance of 'TestPerfTest' has no 'assertIsNone' member [pylint/E1101] [5] > > I think this are false positives having to do with our unittest2 shenanigans. Mind filing a bug for that? Filed https://bugs.webkit.org/show_bug.cgi?id=111108.
Ryosuke Niwa
Comment 5 2013-02-28 13:54:07 PST
Comment on attachment 190635 [details] Cleanup Clearing flags on attachment: 190635 Committed r144363: <http://trac.webkit.org/changeset/144363>
Ryosuke Niwa
Comment 6 2013-02-28 13:54:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.