In latest EFL trunk, include path of ecore sub modules are changed from ecore-1/ to ecore-XXX-1/
Created attachment 190634 [details] Patch
Just in case: no need for a WebKit2 reviewer here. Someone working on EFL should review the patch.
Ryuan, do you need to build WebKit EFL based on latest EFL ? Could you let me know which EFL version you want to build ?
(In reply to comment #3) > Ryuan, do you need to build WebKit EFL based on latest EFL ? Could you let me know which EFL version you want to build ? I used TOT in Efl trunk. I am setting my new PC.
For the record, this is also covered by bug 109819. It's probably a good idea to mention this is about the changes in EFL 1.8 instead of trunk so people in the future know when the directories changed. I did not test the patch myself; if it still works with the current 1.7 series, LGTM.
Comment on attachment 190634 [details] Patch As Kubo mentions, this basically equivalent to my previous patch in the other bug. Looks okay to me except IMO one missing line in + find_package(Ecore 1.6 COMPONENTS Evas File Input Imf Imf_Evas Con ${ECORE_ADDITIONAL_COMPONENTS}) OptionsEfl.cmake - Imf_Evas and Con should be added there, if I am not mistaken.
And it should be tested whether it works with 1.7.5 jhbuild and ToT SVN.
(In reply to comment #5) > For the record, this is also covered by bug 109819. Sorry, I didn't know it. I just searched build break issues. > > It's probably a good idea to mention this is about the changes in EFL 1.8 instead of trunk so people in the future know when the directories changed. Absolutely agree, I will add some comment in FindEcore.cmake. (In reply to comment #6) > (From update of attachment 190634 [details]) > As Kubo mentions, this basically equivalent to my previous patch in the other bug. Looks okay to me except IMO one missing line in > + find_package(Ecore 1.6 COMPONENTS Evas File Input Imf Imf_Evas Con ${ECORE_ADDITIONAL_COMPONENTS}) > OptionsEfl.cmake - Imf_Evas and Con should be added there, if I am not mistaken. Right, Imf_Evas is needed. I will upload patch again. But Ecore_Con, it is only required by Elementary.h. I think that it can be an optional. (In reply to comment #7) > And it should be tested whether it works with 1.7.5 jhbuild and ToT SVN. I tested whether it works with jhbuild and ToT SVN.
Created attachment 191152 [details] Patch
(In reply to comment #8) > (In reply to comment #5) > > For the record, this is also covered by bug 109819. > But Ecore_Con, it is only required by Elementary.h. > I think that it can be an optional. Would this mean that that Minibrowser needs Ecore_Con ? Should we add this dependency than to Tools/MiniBrowser/efl/CMakeLists.txt (but not for the entire project) ?
Created attachment 191418 [details] Patch
(In reply to comment #10) > (In reply to comment #8) > > (In reply to comment #5) > > > For the record, this is also covered by bug 109819. > > > But Ecore_Con, it is only required by Elementary.h. > > I think that it can be an optional. > > Would this mean that that Minibrowser needs Ecore_Con ? Should we add this dependency than to Tools/MiniBrowser/efl/CMakeLists.txt (but not for the entire project) ? Right, MiniBrowser requires Ecore_Con as mandatory package. I tried to move Ecore_Con check routine from FindEcore.cmake to FindElementary.cmake so that Ecore_Con dependency is tested only for MiniBrowser.
LGTM - Rob or Dirk, could you review this?
Comment on attachment 191418 [details] Patch rs=me
Comment on attachment 191418 [details] Patch Thank you.
Comment on attachment 191418 [details] Patch Clearing flags on attachment: 191418 Committed r144842: <http://trac.webkit.org/changeset/144842>
All reviewed patches have been landed. Closing bug.