Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
Created attachment 190621 [details]
Comment on attachment 190621 [details]
looks fine. is there any way to test this (and is it worth it)?
We still can't meaningfully run most of the perf tests in the threaded parser as they use document.write instead of urls to load, but this at least plumbs the option.
I was more wondering if there's some way to stub out / mock some of the calls just to check that the flag is making it through to the driver.
Created attachment 190623 [details]
Patch for landing
Good question. Added a very basic test. I didn't see any other tests using a mock driver for run-perf-tests. This option depends on the driver reading the option, rather than pushing it to the driver, making using a mock driver much less useful anyway. We could use a driver with a MockExecutive and that could work, but I decided this was sufficient for now. If you disagree I can revisit.
Ah. I probably wouldn't have bothered with that test, although it is perhaps better than nothing. It looks like it wouldn't be too hard to add something to perftestsrunner_integrationtest.py that does get all the way through to a mocked-out driver, but I don't know if it's really worth it or important since, as you say, the plumbing was already pretty much there.
I don't think adding flags to DRT is particularly common. I think it should be. :) But I think the threaded parser is the first to do this for a feature in a long time. Next time this comes up we can make this support even more awesome.
If we do start adding more flags to DRT, we should probably at least make --help work :).
Comment on attachment 190623 [details]
Patch for landing
Clearing flags on attachment: 190623
Committed r144253: <http://trac.webkit.org/changeset/144253>
All reviewed patches have been landed. Closing bug.